8000 Upstream source request configuration · Issue #205 · the-guild-org/conductor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 18, 2025. It is now read-only.

Upstream source request configuration #205

Open
dotansimha opened this issue Dec 18, 2023 · 4 comments
Open

Upstream source request configuration #205

dotansimha opened this issue Dec 18, 2023 · 4 comments

Comments

@dotansimha
Copy link
Member
dotansimha 8000 commented Dec 18, 2023

We can add configuration for the source level, not just endpoint.

Some ideas:

  • Method (POST/GET/something else)
  • Headers (static)

And in the future:

  • Subscription protocol (SSE/WS/polling)
@theguild-bot theguild-bot mentioned this issue Dec 18, 2023
Open
63 tasks
@trkohler
Copy link
Contributor
trkohler commented Feb 4, 2024

hello, may I take this one? Seems like a relatively easy issue for onboarding to a project.

@dotansimha
Copy link
Member Author
dotansimha commented Feb 6, 2024 •
edited
Loading

hello, may I take this one? Seems like a relatively easy issue for onboarding to a project.

Sure! Thank you! :) please let me know if we can help!

@trkohler
Copy link
Contributor

@dotansimha like that?

  "sources": [
    {
      "type": "graphql",
      "id": "my-source",
      "method": "POST",
      "headers": [
        { "Authorization": "string" },
        { "Content-Type": "string" },
        { "X-Custom-Header": "string" }
      ],
      "config": {
        "endpoint": "https://my-source.com/graphql"
      }
    }
  ],

@YassinEldeeb
Copy link
Contributor

Yes, exactly as you have described!
This would require extending the config to accept those new fields, and updating the engine executors to use the headers or method if supplied.

This was referenced May 7, 2024
Closed
Closed
Closed
@theguild-bot theguild-bot mentioned this issue May 23, 2024
Closed
63 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dotansimha @trkohler @YassinEldeeb
0