hotfix for buggy Oscar code #1861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
reviewed
Apr 27, 2025
src/NumFieldOrd/NfOrd/NfOrd.jl
Outdated
| @@ -725,6 +725,19 @@ order is cached for future use. | |||
| """ | |||
| function order(K::S, a::Vector{T}; check::Bool = true, isbasis::Bool = false, | |||
| cached::Bool = false) where {S <: NumField{QQFieldElem}, T <: NumFieldElem{QQFieldElem}} | |||
| # hot-fix for some Oscar bug | |||
| # Should be removed once Oscar 1.4(?) is out | |||
There was a problem hiding this comment.
That's not possible, as older Oscar versions may still resolve with that new Hecke.
Instead:
Suggested change
| # Should be removed once Oscar 1.4(?) is out | |
| # Should be removed in a future breaking Hecke release |
There was a problem hiding this comment.
Yes, then one gets the broken version one has now, so no regression.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1861 +/- ##
==========================================
- Coverage 76.58% 76.55% -0.04%
==========================================
Files 363 363
Lines 115064 115072 +8
==========================================
- Hits 88121 88088 -33
- Misses 26943 26984 +41
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.