8000 Update objc default project template by gfontenot · Pull Request #180 · liftoffcli/liftoff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update objc default project template #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2014
Merged

Conversation

gfontenot
Copy link
Member

This brings the objc project template in line with the swift template. This is
actually a lighter weight template, but I think that makes it a better
starting point.

@keith
Copy link
Contributor
keith commented Oct 3, 2014

Works for me.

- Main.storyboard
- Nibs:
- LaunchScreen.xib
- Other-Sources:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should other sources be nested under resources? I know it was like that before but it seems like it should be top level.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they're such low churn it makes sense to nest them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I like that they are stuck out of the way as much as possible.

@hyperspacemark
Copy link
Contributor

I noticed that you removed 'Constants'. What about adding a group for 'Headers' for things like constants files, category import headers and prefix headers?

Other than that, this all looks good.

@gfontenot
Copy link
Member Author

I removed the Constants group because it usually ended up with a single Constants file in it. But Headers sounds like a better place to move that. I'll add a generic Headers group.

@gfontenot gfontenot force-pushed the gf-update-objc-template branch from 618a403 to 9138714 Compare October 6, 2014 14:42
This brings the objc project template in line with the swift template.
This is actually a lighter weight template, but I think that makes it a
better starting point.
@gfontenot gfontenot merged commit 9138714 into master Oct 6, 2014
@gfontenot gfontenot deleted the gf-update-objc-template branch October 6, 2014 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0