8000 Enforce `check` and `lint` on CI · Issue #986 · threlte/threlte · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enforce check and lint on CI #986

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benmccann opened this issue Jun 18, 2024 · 3 comments
Closed

Enforce check and lint on CI #986

benmccann opened this issue Jun 18, 2024 · 3 comments
Assignees
@michealparks

Comments

@benmccann
Copy link
Contributor
benmccann commented Jun 18, 2024 •
edited
Loading

There are a couple of types that are imported without the type signifier and thus unused:

threlte/packages/extras/src/lib/components/Gizmo/Gizmo.svelte

Line 14 in 6ebc7cf

Sprite,

and

https://github.com/threlte/threlte/blob/6ebc7cffdef5bf0e10201e26d15850cace13cd2f/packages/extras/src/lib/components/MeshRefractionMaterial/MeshRefractionMaterial.svelte#L3C19-L3C30

As a result, vite prints a massive warning onto the screen when you don't have the noExternal config: vitejs/vite#17517

If we clean this up we can simplify the user setup instructions: #987
@benmccann
Copy link
Contributor Author
benmccann commented Jun 18, 2024 •
edited
Loading

I was wrong about verbatimModuleSyntax helping here and it's already enabled. I think we need this eslint rule: https://typescript-eslint.io/rules/consistent-type-imports/. Unfortunately there's well over 100 eslint errors already. We should ignore the dumb rules, add consistent-type-imports, and enforce it on the CI

@benmccann benmccann changed the title Set verbatimModuleSyntax in tsconfig Enforce check and lint on CI Jun 18, 2024
@DefinitelyMaybe
Copy link
Collaborator

Hey, sounds like these errors have been giving you a heck of a time. Some clean up is definitely in order 😅

@michealparks michealparks mentioned this issue Jun 19, 2024
Merged
@grischaerbe grischaerbe modified the milestone: Svelte 5 Jun 21, 2024
@michealparks
Copy link
Member

Enforced in CI now 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michealparks michealparks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@benmccann @michealparks @DefinitelyMaybe @grischaerbe
0