8000 CI: migrate to another s3 bucket · Issue #933 · timeplus-io/proton · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
CI: migrate to another s3 bucket #933
Open
Open
< 791E /div>
@yokofly

Description

@yokofly

Describe what's wrong

  1. prebuilt binary pull(v8) && push(macOS binary)
  2. c-cache
  3. CI report log push

current CI script has a bug

proton_log_folder_url = upload_proton_logs(
s3_helper,
proton_log_folder,
pr_number,
commit_sha,
)
print(f"::notice ::Proton server log url: {proton_log_folder_url}")

the pr_number read from env but we shall stick to GITHUB_REF instead GITHUB_REF_NAME ref

3 results - 1 file

tests/stream/ci_runner.py:
  209      if run_mode == "github":
  210:         pr_number = os.getenv("GITHUB_REF_NAME", pr_number)
  211          commit_sha = os.getenv("GITHUB_SHA", commit_sha)

  383      if run_mode == "github":
  384:         pr_number = os.getenv("GITHUB_REF_NAME", "0")
  385          commit_sha = os.getenv("GITHUB_SHA", "0")

  427      os_info = os.getenv("RUNNER_OS", "Linux")
  428:     pr_number = os.getenv("GITHUB_REF_NAME", "0")
  429      commit_sha = os.getenv("GITHUB_SHA", "0")

def upload_proton_logs(s3_client, proton_log_folder, pr_number="0", commit_sha=""):
    s3_proton_log_folder = (
        f"reports/proton/tests/CI/{pr_number}/{commit_sha}/proton_logs"
    )
    proton_log_url = s3_client.upload_test_folder_to_s3(
        proton_log_folder, s3_proton_log_folder
    )
    logging.info("Search result in url %s", proton_log_url)
    return proton_log_url

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0