8000 License · Issue #38 · tolu/ISO8601-duration · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

License #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for Git 8000 Hub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
trew opened this issue Sep 30, 2024 · 2 comments
Open

License #38

trew opened this issue Sep 30, 2024 · 2 comments

Comments

@trew
Copy link
trew commented Sep 30, 2024

This repository does not contain a license file, meaning any tools checking for license compliance will fail on this library. I would recommend including a license file as part of the repository instead of linking to an external site.
@tolu
Copy link
Owner
tolu commented Sep 30, 2024

the license is also listed in package.json, seems weird that that is not picked up by such tools.
What specific tools are you referring to?

@trew
Copy link
Author
trew commented Sep 30, 2024

The MIT license specifies:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

That means it's not enough to just specify that MIT is used. The actual text needs to be provided. Most tools that I've seen look for a file in the distributed package called "LICENSE", "LICENSE.md" or "LICENSE.txt".

Me specifically are using https://www.npmjs.com/package/license-checker in combination with custom tooling to resolve the license texts for distribution, but license-checker resolves the licenseFile field to "README.md", which doesn't contain the license text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tolu @trew
0