8000 mesh.js: Simplify function signature of extractArcs · Issue #340 · topojson/topojson · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

8724 mesh.js: Simplify function signature of extractArcs #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
martinfrances107 opened this issue Aug 31, 2022 · 0 comments
Open

mesh.js: Simplify function signature of extractArcs #340

martinfrances107 opened this issue Aug 31, 2022 · 0 comments

Comments

@martinfrances107
Copy link

This is great module

I am slowly porting this module into RUST here

Porting over the code and all tests, and endeavouring to keep variable and function signature as close to the original java-script as possible,

In short I find myself pouring over the code line by line...

There is a small oversight the first parameter in extractArcs in never read.

-function extractArcs(topology, object, filter) {
+function extractArcs(object, filter) {

So from my perspective, I am about to create a upstream pull request for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martinfrances107
0