8000 Fix markdown_link_check test failures due to GitHub API rate limiting · Issue #1621 · trailofbits/dylint · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix markdown_link_check test failures due to GitHub API rate limiting #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
nowak-token opened this issue May 6, 2025 · 0 comments · Fixed by #1622
Closed
2 tasks done

Fix markdown_link_check test failures due to GitHub API rate limiting #1621

nowak-token opened this issue May 6, 2025 · 0 comments · Fixed by #1622

Comments

@nowak-token
Copy link
Contributor
nowak-token commented May 6, 2025 •
edited
Loading

The CI test markdown_link_check frequently fails with 429 (Too Many Requests) status codes when validating GitHub links. This happens because the test hits GitHub's rate limit for unauthenticated API requests, which is limited to 60 requests per hour.

Currently, the test only allows for empty lines and 500 status codes in its assertion, causing it to fail when encountering 429 errors. The test runs npx markdown-link-check on all markdown files in the repository, which creates numerous requests to GitHub API endpoints.

This issue affects both CI pipelines and local development, making it difficult to run the full test suite reliably.

Checklist:

  • Skip the test when a GitHub token isn't available.
  • Add GitHub token authentication to increase rate limits (from 60 to 5000 requests/hour)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
3CB2
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix markdown_link_check test failures due to GitHub API rate limiting nowak-token/dylint
1 participant
@nowak-token
0