h3ToLocalIjk incorrectly succeeds across a pentagon #163
Assignees
Comments
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm working on the
h3Linealgorithm (#162), and my tests are running into issues when crossing a pentagon onto an adjacent base cell. The following image shows the results ofh3ToLocalIjkfrom the res 3 cell1, 0, 0(next to the0, 0, 0pentagon):This takes a k-ring of 12 and shows only cells with valid coordinates from
h3ToLocalIjk. The cells on the failing sides of the pentagon on the same base cell are excluded, but cells on the adjacent base cell across the pentagon are included (incorrectly, I believe).Looks like the reason for this are the Class III checks here. In the same-cell branch, both
FAILED_DIRECTIONS_IIandFAILED_DIRECTIONS_IIIfail, but in the cross-cell branch they depend on Class III status. Is there a reason for this? This pentagon is base cell 4, which seems to have a few special properties (no CW offset rotation faces inbaseCellData), but I'm not sure if that's relevant here.The text was updated successfully, but these errors were encountered: