8000 Circle not centered around Cursor in Colorful picker · Issue #169 · uiwjs/react-color · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Circle not centered around Cursor in Colorful picker #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hichemfantar opened this issue Mar 13, 2025 · 5 comments
Open

Circle not centered around Cursor in Colorful picker #169

hichemfantar opened this issue Mar 13, 2025 · 5 comments

Comments

@hichemfantar
Copy link

https://uiwjs.github.io/react-color/#/colorful

Screen.Recording.2025-03-13.at.6.54.07.PM.mp4
jaywcjlove added a commit that referenced this issue Mar 14, 2025
@jaywcjlove
fix(Colorful): center circle around cursor in Colorful picker #169.
3287cbf
jaywcjlove added a commit that referenced this issue Mar 14, 2025
@jaywcjlove
released v2.4.2 #169
96c6181
github-actions bot pushed a commit that referenced this issue Mar 14, 2025
@jaywcjlove
v2.4.2 released v2.4.2 #169 96c6181
c358e2b
@jaywcjlove
Copy link
Member

@hichemfantar I’ve made some optimizations and improvements. You can update to v2.4.2 and give it a try. Feel free to further optimize and submit a PR!

jaywcjlove added a commit that referenced this issue 8000 Mar 14, 2025
@jaywcjlove
fix(Colorful): center circle around cursor in Colorful picker. #169
d0ace0c
jaywcjlove added a commit that referenced this issue Mar 14, 2025
@jaywcjlove
released v2.4.3 #169
019d99e
@alexfoxy
Copy link

Not sure if this has introduced a bug - the colour circle is not set correctly on initial load. You can see it on your website: https://uiwjs.github.io/react-color/#/colorful

Image

jaywcjlove added a commit that referenced this issue Mar 14, 2025
@jaywcjlove
fix: fix Saturation default value issue. #169
7a71cdc
jaywcjlove added a commit that referenced this issue Mar 14, 2025
@jaywcjlove
released v2.4.4 #169
35b9c81
@jaywcjlove
Copy link
Member

@alexfoxy I’ve fixed it, and it looks fine now.

github-actions bot pushed a commit that referenced this issue Mar 14, 2025
@jaywcjlove
v2.4.4 released v2.4.4 #169 35b9c81
49b23ae
@alexfoxy
Copy link

Amazing thank you!

@hichemfantar
Copy link
Author

Can y’all share screenshots?

I feel like it’s not exactly centered in my case and is slightly inconsistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexfoxy @jaywcjlove @hichemfantar
0