8000 Remove obsolete variables and their left over functionality · Issue #3007 · ukaea/PROCESS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Remove obsolete variables and their left over functionality #3007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
10 tasks done
chris-ashe opened this issue Dec 4, 2023 · 0 comments · Fixed by #3009
Closed
10 tasks done

Remove obsolete variables and their left over functionality #3007

chris-ashe opened this issue Dec 4, 2023 · 0 comments · Fixed by #3009
Assignees
@chris-ashe

Comments

@chris-ashe
Copy link
Collaborator
chris-ashe commented Dec 4, 2023 •
edited
Loading

There are some variables which seem to be obsolete though are still hanging around in the code. They should be removed

  • fimpvar seems to be obsolete though is not stated as such

  • impvar id obsolete so should be documented as such

  • ifispact and all associated variables should be removed, as it is not used.

  • rho_ecrh seems to be obsolete so should be removed.

  • All fms* variables seem to be useless
    real(dp) :: fmsbc
    !! Martensitic fraction of steel in (non-existent!) bucking cylinder

    real(dp) :: fmsbl
    !! Martensitic fraction of steel in blanket

    real(dp) :: fmsdwe
    !! Martensitic fraction of steel in cryostat

    real(dp) :: fmsdwi
    !! Martensitic fraction of steel in vacuum vessel

    real(dp) :: fmsfw
    !! Martensitic fraction of steel in first wall

    real(dp) :: fmsoh
    !! Martensitic fraction of steel in central solenoid

    real(dp) :: fmssh
    !! Martensitic fraction of steel in shield

    real(dp) :: fmstf
    !! Martensitic fraction of steel in TF coil

  • farc4tf seems to be obsolete and should be removed

  • quench_detection_ef seems to be obsolete. CHECK QUENCH MODEL

  • iprimnloss seems to be obsolete

  • divleg_profile_inner and divleg_profile_outer seem to be obsolete

  • fgamp is seemingly obsolete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chris-ashe chris-ashe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP:3007 remove obsolete variables and their left over functionality ukaea/PROCESS
1 participant
@chris-ashe
0