Open
Description
Hi 👋
I see that it was the only change in 0.19.1 - #453 and it seems like it impacted some module loading logic and I'm getting different formatting between CLI vs VSCode built-in formatting capabilities with Prettier plugin.
In 0.19.0 I see it loaded ESM version:
In 0.19.1 it seems to be loading CJS version:
I'm not sure why this impacts formatting in any way, but it's the only change I could found while debugging. This is example code which is formatted differently between these two versions:
const getDataForRatingOrDeleting = SqlSchema.single({
execute: (request) => sql`
SELECT
${sql("id")},
${sql("agentId")}
FROM
${sql("conversation")}
WHERE
${sql.and([
sql`${sql("id")} = ${request.id}`,
sql`${sql("userId")} = ${request.userId}`,
sql`${sql("deletedAt")} IS NULL`,
])};
`,
Request: ConversationModel.update.pick("userId", "id"),
Result: ConversationModel.select.pick("id", "agentId"),
});
My prettier config:
/**
* @type {import("prettier").Config}
*/
const prettierConfig = {
printWidth: 120,
useTabs: true,
objectWrap: "collapse",
experimentalOperatorPosition: "start",
experimentalTernaries: true,
plugins: ["prettier-plugin-embed", "prettier-plugin-sql"],
overrides: [{ files: "*.svg", options: { parser: "html" } }],
};
/**
* @type {import("prettier-plugin-embed").PluginEmbedOptions}
*/
const prettierPluginEmbedConfig = { embeddedSqlPlugin: "prettier-plugin-sql", embeddedSqlParser: "mysql" };
/** @type {import('prettier-plugin-sql').SqlBaseOptions} */
const prettierPluginSqlConfig = {
language: "mysql",
keywordCase: "upper",
dataTypeCase: "upper",
functionCase: "upper",
identifierCase: "upper",
};
export default { ...prettierConfig, ...prettierPluginEmbedConfig, ...prettierPluginSqlConfig };
Metadata
Metadata
Assignees
Labels
No labels