8000 [prettier-plugin-sql] Pin version of `sql-formatter` · Issue #481 · un-ts/prettier · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
[prettier-plugin-sql] Pin version of sql-formatter #481
Closed as not planned
Closed as not planned
@jGleitz

Description

@jGleitz

sql-formatter released a fix for handling the UUID type last week. The fix is good, but the version update silently broke our build, because the checked-in SQL files were no longer formatted correctly.

We expect a formatter’s output not to change as long as we don’t update its version. But here, the formatter’s output changed silently, breaking our build, and leaving us with no clue as to why it happened.

This happened because the sql-formatter dependency accepts any new version with the same major version. We can debate whether sql-formatter shouldn’t have marked its release as a breaking change by increasing the major version. Nevertheless, we think that this plugin should pin the version of sql-formatter to ensure that the output never changes without a version update.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0