Bug: SolidJS effect does not get triggered on setter #53

Shinigami92 · 2025-06-27T22:33:26Z

Shinigami92
Jun 27, 2025
Maintainer

Code:

Lines 138 to 150 in 8f238f9

    
           const state = createSolidSignal(signal.get()); 
        
           if (!readonly) { 
        
             createSolidEffect(() => { 
        
               const value = state[0](); 
        
               signal.set(value); 
        
             }); 
        
           } 
        
           unEffect(() => state[1](() => signal.get())); 
        
           // @ts-expect-error: just do it 
        
           return readonly ? state[0] : state;

Test:

unuse/packages/unuse-solid/src/index.spec.ts

Lines 54 to 66 in 8f238f9

    
           it.todo('should resolve an UnSignal to a Solid Signal', () => { 
        
             const mySignal = unSignal(42); 
        
             renderHook(() => { 
        
               const resolved = unResolve(mySignal); 
        
               expect(resolved[0]()).toBe(42); 
        
               resolved[1](100); 
        
               return resolved; 
        
             }); 
        
             expect(mySignal.get()).toBe(100); 
        
           });

expect(mySignal.get()).toBe(100); results in 42 instead of 100.

@ryansolid could you maybe explain why the createSolidEffect gets triggered? And can I somehow trigger it?

XiNiHa · 2025-07-03T18:36:13Z

XiNiHa
Jul 3, 2025

Have you tried using createComputed instead of createEffect? The effect is mainly for actual side effects on the leaf of the tree. createComputed should be used for derived values like this case.

1 reply

Shinigami92 Jul 3, 2025
Maintainer Author

Thanks! I will investigate more about that. We need tips like that from the community ❤️

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Bug: SolidJS effect does not get triggered on setter #53

Uh oh!

{{title}}

Uh oh!

Replies: 1 comment 1 reply

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Select a reply

Uh oh!

Uh oh!

Bug: SolidJS effect does not get triggered on setter #53

Uh oh!

Shinigami92 Jun 27, 2025 Maintainer

Replies: 1 comment · 1 reply

Uh oh!

XiNiHa Jul 3, 2025

Uh oh!

Uh oh!

Shinigami92 Jul 3, 2025 Maintainer Author

Shinigami92
Jun 27, 2025
Maintainer

Replies: 1 comment 1 reply

XiNiHa
Jul 3, 2025

Shinigami92 Jul 3, 2025
Maintainer Author