8000 Ensure app-config.json test data is valid · Issue #223 · uncefact/tests-untp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Ensure app-config.json test data is valid #223
Open
@absoludity

Description

@absoludity

Is your feature request related to a problem? Please describe.

I noticed while reviewing #221 that there seems to be invalid test data that is embedded in the repository within app-config.json files (and I don't mean invalid jsonld, but invalid according to the spec/schema). This data seems to be used for e2e tests as well as as examples to users of the repo.

As an example, these lines of the root ./app-config.json define some of the properties of a DPP, but both the context and the type are invalid as they are - the context needs to have the VC context as the first item, and the type needs to include the VC type as well?

Note: I could be wrong and perhaps this data defines some base which is added to correctly - I've not checked the code, but it would be odd to not include the correct context and type here. Not sure, I've not looked closely at the e2e setup, feel free to close if that's incorrect.

If it is the case, we may want to wait for the final 0.6.0 before updating all the data in the app-config.json files.

Files:

  • ./packages/mock-app/src/constants/app-config.json
  • ./packages/components/build/constants/app-config.json
  • ./packages/components/src/constants/app-config.json
  • ./e2e/cypress/fixtures/app-config.json
  • ./app-config.json

Describe the solution you'd like

Any test data (such as DDPs or similar) used in e2e tests of the tests-untp repo should be valid.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    Todo

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0