8000 feat: `event.waitUntil` with cloudflare integration by pi0 Β· Pull Request #1421 Β· nitrojs/nitro Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: event.waitUntil with cloudflare integration #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 12, 2023
Merged

feat: event.waitUntil with cloudflare integration #1421

merged 5 commits into from
Jul 12, 2023

Conversation

pi0
Copy link
Member
@pi0 pi0 commented Jul 12, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

#1420

This PR supports platform-agnostic event.waitUntil that keeps promises under event.context.nitro._waitUntilPromises (private - unused) and also adds integration with all clodflare presets (https://developers.cloudflare.com/workers/runtime-apis/fetch-event/#waituntil)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link
codecov bot commented Jul 12, 2023 •
edited
Loading

Codecov Report

Merging #1421 (a5346aa) into main (f12b38e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head a5346aa differs from pull request most recent head 6a9a093. Consider uploading reports for the commit 6a9a093 to get more accurate results

@@            Coverage Diff             @@
##             main    #1421      +/-   ##
==========================================
+ Coverage   76.79%   76.82%   +0.02%     
==========================================
  Files          71       71              
  Lines        7310     7317       +7     
  Branches      729      729              
==========================================
+ Hits         5614     5621       +7     
  Misses       1695     1695              
  Partials        1        1
Impacted Files Coverage Ξ”
src/types/h3.ts 100.00% <100.00%> (ΓΈ)

@pi0 pi0 mentioned this pull request Jul 12, 2023
Closed
4 tasks
@pi0 pi0 changed the title feat: event.waitUntil with cloudflare integration support feat: event.waitUntil with cloudflare integration Jul 12, 2023
@pi0 pi0 merged commit 574d892 into main Jul 12, 2023
@pi0 pi0 deleted the feat/wait-until branch July 12, 2023 20:41
@pi0 pi0 mentioned this pull request Jul 12, 2023
Merged
7 tasks
@pi0 pi0 mentioned this pull request Aug 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pi0
0