8000 Re-exporting types from another package are not properly marked as type-only export in declaration file. · Issue #422 · unjs/unbuild · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Re-exporting types from another package are not properly marked as type-only export in declaration file. #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

8000
Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
NamesMT opened this issue Jul 25, 2024 · 4 comments
Open

Re-exporting types from another package are not properly marked as type-only export in declaration file. #422

NamesMT opened this issue Jul 25, 2024 · 4 comments
Labels
bug Something isn't working dts

Comments

@NamesMT
Copy link
NamesMT commented Jul 25, 2024

Environment

Both unbuild@latest (2) and unbuild@rc (3rc7)
NodeJS 20

Reproduction

https://github.com/NamesMT/sencrypt

Describe the bug

I am trying to re-export the class SHash as a type-only export:

export type { SHash } from '@namesmt/shash'

// Also tried this syntax:
export { type SHash } from '@namesmt/shash'

But the index.d.mts declaration result is:

export { SHash } from '@namesmt/shash';

Which is not correct and in the IDE of the end-user it seemed like they could import and use SHash as a class, but it will error at runtime.

Additional context

No response

Logs

No response
@NamesMT NamesMT added the bug Something isn't working label Jul 25, 2024
@s3xysteak
Copy link
Contributor
s3xysteak commented Aug 5, 2024 •
edited
Loading

Refer to source, unbuild use rollup-plugin-dts to generate d.ts.

So it is a issue of rollup-plugin-dts. Consider the plugin has been in Maintenance Mode, maybe it will be a long time to resolve it...

@cangSDARM
Copy link

I have a simular issue. my dts generated a _mergeNamespaces function, which just a "any" wrap 🤔

source:

export * as Rx from 'rxjs'

generated:

import * as rxjs from 'rxjs';

function _mergeNamespaces(n, m) {
  m.forEach(function (e) {
    e && typeof e !== 'string' && !Array.isArray(e) && Object.keys(e).forEach(function (k) {
      if (k !== 'default' && !(k in n)) {
        var d = Object.getOwnPropertyDescriptor(e, k);
        Object.defineProperty(n, k, d.get ? d : {
          enumerable: true,
          get: function () { return e[k]; }
        });
      }
    });
  });
  return Object.freeze(n);
}

var rx = /*#__PURE__*/_mergeNamespaces({
  __proto__: null
}, [rxjs]);

export { rx as Rx };

@pi0 pi0 added the dts label Dec 27, 2024
@gxres042
Copy link

So it is a issue of rollup-plugin-dts. Consider the plugin has been in Maintenance Mode, maybe it will be a long time to resolve it...

How about trying rollup-plugin-flat-dts?

@kricsleo
Copy link
Member
kricsleo commented Feb 7, 2025

Upstream issue: Swatinem/rollup-plugin-dts#311
and should be resolved by pr: Swatinem/rollup-plugin-dts#333
(merged but not released yet ⌛)

@mrginglymus mrginglymus mentioned this issue Feb 27, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pi0 @cangSDARM @NamesMT @kricsleo @gxres042 @s3xysteak
0