8000 Add Guinea holidays · Issue #1194 · vacanza/holidays · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Guinea holidays #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arkid15r opened this issue May 15, 2023 · 4 comments · Fixed by #2398
Closed

Add Guinea holidays #1194

arkid15r opened this issue May 15, 2023 · 4 comments · Fixed by #2398
Assignees
@nalin-28
Labels
help wanted

Comments

@arkid15r
Copy link
Collaborator

Links:
@arkid15r arkid15r mentioned this issue May 15, 2023
Open
@arkid15r arkid15r mentioned this issue Feb 9, 2025
Open
@arkid15r arkid15r moved this to Todo in Task Tracker Mar 29, 2025
@nalin-28
Copy link
Contributor

I want to work on this. Also, Guinea has Lailat al-Qadr (https://www.timeanddate.com/holidays/guinea/laylat-al-qadr) as one of its public holidays and this holiday is not added in IslamicHolidays. So, can you assist me on how to add this to IslamicHolidays file.

@arkid15r arkid15r moved this from Todo to In Progress in Task Tracker Mar 29, 2025
@KJhellico
Copy link
Collaborator
KJhellico commented Mar 29, 2025 •
edited
Loading

@nalin-28, as Lailat-al-Qadr also actual for Ivory Coast, so look at my suggestion about it.

@nalin-28
Copy link
Contributor

@KJhellico I saw the Ivory Coast Pull Request and Laylat al-Qadr has been implemented by Kriti Birda. So, should I take the code and implement it in my Pull Request too or should I wait till it gets added to the main branch?

@KJhellico
Copy link
Collaborator

You can add needed code to your branch for now, and when that PR will be 9589 merged, you can merge (if you'll have already published your PR by that time) or rebase (if not yet) on dev.

@nalin-28 nalin-28 mentioned this issue Mar 31, 2025
Merged
9 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Task Tracker Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nalin-28 nalin-28

Labels
help wanted
Projects
Task Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Guinea holidays nalin-28/holidays_copy
3 participants
@arkid15r @KJhellico @nalin-28
0