8000 Upgrade date-fns to v3.6.0 · Issue #5 · vercel/little-date · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Upgrade date-fns to v3.6.0 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mirshko opened this issue Aug 21, 2024 · 2 comments
Open

Upgrade date-fns to v3.6.0 #5

mirshko opened this issue Aug 21, 2024 · 2 comments

Comments

@mirshko
Copy link
mirshko commented Aug 21, 2024

With the recent typescript native upgrade to date-fns v3 this package should be updated to use the latest version of date-fns as it had no breaking changes if I remember correctly.
@fxamauri
Copy link

It could also be a good idea to make date-fns a peer dependency, as it would give users more flexibility with versions. What do you think?

 "peerDependencies": {
    "date-fns": ">=2.0.0",
  },

@mirshko
Copy link
Author
mirshko commented Aug 21, 2024

I'd be in support of @fxamauri's idea!

I think a lot of people who would use this library would also be using date-fns in other places, so it makes sense to make this a peer dep!

@simonljus simonljus mentioned this issue Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mirshko @fxamauri
0