8000 sql_connection It might be better to set PoolSize not to MaxPoolSize when MaxPoolSize==0 · Issue #9 · viant/dsc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
sql_connection It might be better to set PoolSize not to MaxPoolSize when MaxPoolSize==0 #9
New issue
New issue
Open
Open
sql_connection It might be better to set PoolSize not to MaxPoolSize when MaxPoolSize==0#9
@ZhengweiHou

Description

@ZhengweiHou
ZhengweiHou
opened on May 11, 2023

dsc/sql_connection.go

Lines 139 to 148 in 9279ced

func newSQLConnectionProvider(config *Config) ConnectionProvider {
if config.MaxPoolSize == 0 {
config.MaxPoolSize = 1
}
sqlConnectionProvider := &sqlConnectionProvider{}
var connectionProvider ConnectionProvider = sqlConnectionProvider
super := NewAbstractConnectionProvider(config, make(chan Connection, config.MaxPoolSize), connectionProvider)
sqlConnectionProvider.AbstractConnectionProvider = super
return connectionProvider
}

It might be better to set PoolSize not to MaxPoolSize when MaxPoolSize==0

	if config.PoolSize == 0 {
		config.PoolSize = 1
	}
	if config.MaxPoolSize == 0 {
		config.MaxPoolSize = config.PoolSize
	}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0