8000 chore: Update PR template (#8750) · videojs/video.js@c5f548b · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Commit c5f548b

Browse files
mister-benmister-ben
authored
chore: Update PR template (#8750)
Adds reminders to check impact of JSDoc and DOM changes.
1 parent 4de09e4 commit c5f548b

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

‎.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,6 @@ Please list the specific changes involved in this pull request.
1313
- [ ] Unit Tests updated or fixed
1414
- [ ] Docs/guides updated
1515
- [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
16+
- [ ] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
17+
- [ ] Has no changes to JSDoc which cause `npm run docs:api` to error
1618
- [ ] Reviewed by Two Core Contributors

0 commit comments

Comments
 (0)
0