8000 Make do_not_raise a keyword argument to create_x() instead of a class attribute · Issue #44 · vikinganalytics/mvg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make do_not_raise a keyword argument to create_x() instead of a class attribute #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OskarLiew opened this issue Jul 27, 2021 · 0 comments · Fixed by #55
Closed

Make do_not_raise a keyword argument to create_x() instead of a class attribute #44

OskarLiew opened this issue Jul 27, 2021 · 0 comments · Fixed by #55
Assignees
@OskarLiew

Comments

@OskarLiew
Copy link
Contributor

I often find myself confused about why some errors get swallowed. I think it would be more convenient to add a exist_ok flag for create_x() methods, similar to Path.mkdir, to make it more intuitive.

It would also make it easier for the CLI, where we want to tell the user that there has been a conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OskarLiew OskarLiew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moved ignore error to kwarg vikinganalytics/mvg
1 participant
@OskarLiew
0