8000 Tab completion kills quoted strings · Issue #222 · vit-project/vit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Tab completion kills quoted strings #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for Git 8000 Hub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thehunmonkgroup opened this issue Jan 12, 2020 · 2 comments
Closed

Tab completion kills quoted strings #222

thehunmonkgroup opened this issue Jan 12, 2020 · 2 comments
Labels
bug help wanted

Comments

@thehunmonkgroup
Copy link
Member

Scenario:

  1. Activate the command bar to modify a task
  2. Enter "foo bar" project:, then hit the tab key
  3. Notice that the quotes around foo bar have been removed
@thehunmonkgroup thehunmonkgroup mentioned this issue Jan 12, 2020
Closed
@thehunmonkgroup
Copy link
Member Author

This has turned out to be more challenging that I had first hoped -- it's not clear to me how shlex, the parser we use, can be configured to output what we need.

If anybody wants to dig through their documentation and submit a PR, that would be helpful. Basically, the call to util.string_to_args in function parse_text of autocomplete.py is currently stripping quotes, and we need it to preserve them while still properly separating the other args: https://docs.python.org/3/library/shlex.html

@thehunmonkgroup thehunmonkgroup mentioned this issue Mar 6, 2020
Closed
@thehunmonkgroup
Copy link
Member Author

41d046e should mostly fix this.

Closing this for now, a more long-term solution can be dealt with in #230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thehunmonkgroup
0