8000 🐛 [Bug] 1.6.1.4544 build failing · Issue #2741 · vmangos/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🐛 [Bug] 1.6.1.4544 build failing #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mserajnik opened this issue Aug 29, 2024 · 0 comments
Closed

🐛 [Bug] 1.6.1.4544 build failing #2741

mserajnik opened this issue Aug 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mserajnik
Copy link
Contributor
mserajnik commented Aug 29, 2024 •
edited
Loading

🐛 Bug report

Building for 1.6.1.4544 is currently failing:

/core/src/game/Objects/Player.cpp: In member function 'InventoryResult Player::CanUnequipItem(uint16, bool) const':
/core/src/game/Objects/Player.cpp:10335:16: error: 'EQUIP_ERR_NOT_WHILE_DISARMED' was not declared in this scope
10335 |         return EQUIP_ERR_NOT_WHILE_DISARMED;
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Full context here (the output is alternating between the x86_64 and aarch64 builds which is why it looks so discontinuous).

I assume the error occurs due to this addition in 2f500b9:

core/src/game/Objects/Player.cpp

Lines 10333 to 10335 in ce50f98

// you cannot unequip main hand weapon while disarmed
if (IsMainHandPos(pos) && HasFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_DISARMED))
return EQUIP_ERR_NOT_WHILE_DISARMED;

Because EQUIP_ERR_NOT_WHILE_DISARMED is not defined when building for 1.6.1.4544:

core/src/game/Objects/Item.h

Lines 108 to 109 in ce50f98

#if SUPPORTED_CLIENT_BUILD > CLIENT_BUILD_1_6_1
EQUIP_ERR_NOT_WHILE_DISARMED, // ERR_NOT_WHILE_DISARMED

Commit Hash: ce50f98

OS Server: Ubuntu 24.04 LTS
@mserajnik mserajnik added the bug Something isn't working label Aug 29, 2024
@mserajnik mserajnik mentioned this issue Mar 27, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mserajnik
0