8000 🐛 [Bug] Loot log file and LevelUp log file are wrongly named in code · Issue #2982 · vmangos/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🐛 [Bug] Loot log file and LevelUp log file are wrongly named in code #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy stat 8000 ement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DSkywalk opened this issue Mar 27, 2025 · 0 comments · Fixed by #2983
Closed

🐛 [Bug] Loot log file and LevelUp log file are wrongly named in code #2982

DSkywalk opened this issue Mar 27, 2025 · 0 comments · Fixed by #2983
Labels
bug Something isn't working

Comments

@DSkywalk
Copy link
Contributor
DSkywalk commented Mar 27, 2025 •
edited
Loading

🐛 Bug report

Loot.txt and LevelUp.txt logs are always generated from this commit because the token names in the code are wrong:

  • LootsLogFile => LogFile.Loot
  • LevelupLogFile => LogFile.LevelUp

Code change:
89e918e#diff-93eef7c860a081602c2a653fabf9e763c4384496c22aeb72cb110c0ff2d03991R109

Expected behavior

If you set LogFile.Loot = "" or LogFile.LevelUp = " the log should not be generated.

Steps to reproduce

  1. set LogFile.Loot = ""
  2. see your loot log on your logs folder created and growing...

Affected Commit Hash:

(89e918e#diff-93eef7c860a081602c2a653fabf9e763c4384496c22aeb72cb110c0ff2d03991R109)

Thanks for your great work, if you want I could prepare a PR to fix it 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Loot.txt and LevelUp.txt logs are always generated DSkywalk/vmangos-core
1 participant
@DSkywalk
0