8000 PaymentRequestEvent.OpenWindow() could fail in two different ways · Issue #361 · w3c/payment-handler · GitHub

More Web Proxy on the site http://driver.im/

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaymentRequestEvent.OpenWindow() could fail in two different ways #361

Open

maxlgu opened this issue Jan 31, 2020 · 1 comment

Contributor

maxlgu commented

•

PaymentRequestEvent.OpenWindow(url) could fail in two different ways:

reject - for example, "If url is about:blank, return a Promise rejected with a TypeError."
resolve with null - for example, "If url's origin is not the same as the service worker's origin associated with the payment handler, return a Promise resolved with null."

What's the purpose of having two ways to refuse a failed "OpenWindow()". Can we merge them for developer ergonomics?

(link to the Chrome Implementation discussion: crbug.com/1046120)

Collaborator

rsolomakhin commented

@maxlgu - I would prefer that openWindow() reject in both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

0