Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 4 commits
- 1 file changed
- 1 contributor
Commits on Apr 5, 2024
-
Update regex matching to handle proper class escaping
On Python 3.12 it's throwing compile warnings on the regex compiles: ``` spdx/verify-spdx-headers:8: SyntaxWarning: invalid escape sequence '\s' SPDX = re.compile(f'SPDX-License-Identifier:\s+({SLUG.pattern})') spdx/verify-spdx-headers:21: SyntaxWarning: invalid escape sequence '\s' pattern = f"^{init}\s*{SPDX.pattern}\s*{fini}\\s*$" spdx/verify-spdx-headers:21: SyntaxWarning: invalid escape sequence '\s' pattern = f"^{init}\s*{SPDX.pattern}\s*{fini}\s*$" ``` This escapes the the '\s' to be '\\s' instead as that is compliant, seems to compile correctly, and makes the warning go away. Quick checking on my own repos seemed to not break anything. Signed-off-by: John 'Warthog9' Hawley <jhawley@tenstorrent.com> -
This more or less matches c++ with the exception that it's an interpretted language and in theory could use the shebang syntax. should work on .ts files. Signed-off-by: John 'Warthog9' Hawley <jhawley@tenstorrent.com>
-
Ignore symlinks in the tree walk
Trying to open a symlink directly doesn't go well, and may reference things outside the repository. Assuming that a symlink doesn't need to be independently opened and checked as if the file is in the repository it'll get picked up elsewhere, and this would just be a dupe, or if it's external it's not part of the repository and not entirely useful to check anyway. If it's a symlink, just skip it. Signed-off-by: John 'Warthog9' Hawley <jhawley@tenstorrent.com>
Commits on Apr 8, 2024
-
feat: add shell (.sh) checking
This more or less matches python, and should be fine for just about all shells that make use of '.sh' (typically) as a file extension should work on .sh files. Signed-off-by: John 'Warthog9' Hawley <jhawley@tenstorrent.com>
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master