8000 Broken comic - TheGamerCat · Issue #268 · webcomics/dosage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Broken comic - TheGamerCat #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Typhonragewind opened this issue Jun 1, 2023 · 3 comments
Open

Broken comic - TheGamerCat #268

Typhonragewind opened this issue Jun 1, 2023 · 3 comments

Comments

@Typhonragewind
Copy link
Contributor

This one seems to be broken, but i think the fault lies in the comic server itself and not in dosage, as i get this error:

TheGamerCat> ERROR: ("Connection broken: InvalidChunkLength(got length b'', 0 bytes read)", InvalidChunkLength(got length b'', 0 bytes read))

Don't know if there is anything that can be done about it, but i'm leaving the report here

I tried to rewrite the class to use the basicparser, and i still get the same error
@TobiX
Copy link
Member
TobiX commented Jun 2, 2023

That cannot be fixed by using a different parser, the server sends invalid chunked responses...

This also fails:

$ curl --http1.1 --fail-with-body -o pawsed.html https://thegamercat.com/comic/pawsed/
curl: (18) transfer closed with outstanding read data remaining

Even HTTP2 fails:

$ curl --fail-with-body -o pawsed.html https://thegamercat.com/comic/pawsed/
curl: (92) HTTP/2 stream 1 was not closed cleanly: INTERNAL_ERROR (err 2)

😞

@TobiX TobiX added the bug label Jun 2, 2023
@Typhonragewind
Copy link
Contributor Author

I was experimenting with it a bit more and there was one instance where it succeeded (just by retrying multiple times), so perhaps a multiple retry approach MIGHT work, as ugly as it sounds

@TobiX TobiX removed the bug label May 19, 2025
@TobiX
Copy link
Member
TobiX commented May 19, 2025

I'm very undecided if we can/should do anything about this... Maybe this should be covered by urllib3's Retry feature (which we are using), but AFAICS it currently sees InvalidChunkLength as a fatal error which shouldn't been retried...

See:
https://github.com/urllib3/urllib3/blob/98634f7a5a0f39029a21e9f49e9066a8f99a1515/src/urllib3/util/retry.py#L373-L377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TobiX @Typhonragewind
0