8000 Node v4 support · Issue #788 · wekan/wekan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Node v4 support #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xet7 opened this issue Feb 7, 2017 · 11 comments
Closed

Node v4 support #788

xet7 opened this issue Feb 7, 2017 · 11 comments

Comments

@xet7
Copy link
Member
xet7 commented Feb 7, 2017

From @HLFH on November 21, 2016 14:30

Hi,

Meteor supports Node v4, so Wekan should support Node v4.

Copied from original issue: wefork#23
@xet7
Copy link
Member Author
xet7 commented Feb 7, 2017

@HLFH

Please see 2) of https://github.com/wefork/wekan/wiki/FAQ

@xet7
Copy link
Member Author
xet7 commented Feb 7, 2017

From @HLFH on November 21, 2016 17:35

Node API changes between v.0.10 and v4

Meteor upgrade to Nodev4 ok
Meteor upgrade to Nodev6 not ok for now

Wekan related issues:
#634
#677

This was referenced Feb 7, 2017
Closed
Closed
@xet7
Copy link
Member Author

@kentonv

Is Wekan also stuck in Node 0.10.x because of capnp?
capnproto/node-capnp#28

I did run into capnp build problems when I did try to build Wekan using:

  • Node v4.7.3
  • NPM v4.2.0
  • Meteor v1.4.2.7

If upgrade is not possible, I'll probably need to find a way to change package
versions in Meteor v1.3.5.1 to get t9n translations into Wekan
#854 , with a fork of Meteor v1.3.5.1
or some changes to build script.

@kentonv
Copy link
kentonv commented Feb 20, 2017 •
edited
Loading

@xet7 TL;DR: Sandstorm should not block this update.

node-capnp has a node4 branch which is actually now the default branch. Note that Sandstorm apps cannot use capnp from npm due to Sandstorm requiring unreleased features. But, we actually bundle a working copy of the capnp module into meteor-spk, so require()ing it should "just work" without declaring any explicit dependency -- as if it were a Node builtin.

You will, though, need to update to the latest meteor-spk in order to support Meteor 1.4+. I suppose Wekan must currently be building with a previous version of meteor-spk since it's still on Meteor 1.3.

@dwrensha probably has more context on this than I do.

@ocdtrekkie
Copy link
Contributor

@kentonv: @dwrensha is currently using a locally modified version of meteor-spk 0.2.1 and a monkey patch to Wekan code, detailed here: #823

@dwrensha
Copy link
Contributor

Yes, upgrading Wekan to Meteor 1.4 should make things simpler on the Sandstorm end.

I did run into capnp build problems when I did try to build Wekan using....

@xet7 what kind of build problems? I imagine they would go away if you used meteor-spk v0.3.1.

@xet7
Copy link
Member Author
xet7 commented Mar 28, 2017

@datamaker

Can you try to continue your Meteor 1.4 port or Wekan
https://github.com/datamaker/wekan
with node4 branch of capnp?
https://github.com/kentonv/node-capnp

It could help with #928

Sandstorm build instructions are at #823

@stephenmoloney
Copy link
Contributor

@datamaker,
If it's any help, you can test the build process without changing the dockerfile by changing the ARGS

Directions here

That said, that does not exclude the potential need for changes to the Dockerfile to make it work.

@xet7 xet7 mentioned this issue Mar 30, 2017
Closed
@brylie brylie mentioned this issue Mar 30, 2017
Merged
@brylie
Copy link
Contributor
brylie commented Mar 30, 2017

Hi all. I opened a PR with a Meteor 1.4.x upgrade (#957). Please test and review.

This was referenced Apr 5, 2017
Closed
Closed
@xet7
Copy link
Member Author
xet7 commented May 6, 2017

Node v4 works now and is used on master, devel and meteor-1.4 branches.

@xet7 xet7 closed this as completed May 6, 2017
@HLFH
Copy link
HLFH commented May 8, 2017

Thank you @xet7

@snyk-bot snyk-bot mentioned this issue Mar 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@xet7 @brylie @dwrensha @HLFH @kentonv @ocdtrekkie @stephenmoloney
0