8000 An edge-to-edge URL makes description uneditable · Issue #1389 · wekan/wekan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

An edge-to-edge URL makes description uneditable #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uusijani opened this issue Dec 9, 2017 · 10 comments
8000 Open

An edge-to-edge URL makes description uneditable #1389

uusijani opened this issue Dec 9, 2017 · 10 comments

Comments

@uusijani
Copy link
uusijani commented Dec 9, 2017

Issue

Impacted version: 0.60

Server Setup Information:

  • Operating System: Ubuntu 16.04
  • Deployment Method: snap
  • ROOT_URL environment variable (Is there a subfolder?): https://my-domain.com/kan (yes)

Problem description:
A description consisting entirely of a URL that happens to extend from the left edge to the right edge of the description field (e.g. https://github.com/mattermost/mattermost-mobile/releases/tag/v1.5.0) makes it impossible to edit the description, as clicking anywhere on the viewer lands the click on the URL, which triggers a new browser tab instead of the editor.

Here's a screenshot of such a URL overlapping the editing area, as highlighted by the inspector in Firefox.

wekan-description-url

There's actually a couple of pixels worth of unlinked, clickable editor area at the right edge here, but you need a really steady hand and mouse to hit those pixels.

A workaround seems to be to change the browser zoom level (either way), causing the URL to extend either over to the next line or properly short of the right edge of the first line (turning the rest of the line clickable).

@xet7
Copy link
Member
xet7 commented Dec 20, 2017

@uusijani

Workaround as markdown:

[v1.5.0](https://github.com/mattermost/mattermost-mobile/releases/tag/v1.5.0)

@xet7
Copy link
Member
xet7 commented Dec 20, 2017

This was previously fixed at #1073 , something has made it appear again.

I'm not sure is this related to double slash regression on snap

@xet7 xet7 added the Bug label Dec 20, 2017
@uusijani
Copy link
Author

For me the double slash regression occurred at 0.62-3-g74877fd (as it did for the reporter in #1405), whereas this edge-to-edge URL issue was already there in 0.60 (but the double slash issue wasn't). It might not definitely make them completely unrelated, but would at least hint towards it.

@xet7
Copy link
Member
xet7 commented Jan 15, 2018

@uusijani

Please test newest Ubuntu Snap, is double slash bug now fixed.

It seems to work for me.

@uusijani
Copy link
Author

@xet7 When I try to refresh the snap, it gets stuck in Run configure hook of "wekan" snap if present with a node process eating up the CPU. It takes 5 minutes before snapd gives up. Now the service won't come back up, and revert also fails:

root@battra:~# snap revert wekan
error: cannot perform the following tasks:
- Run configure hook of "wekan" snap if present (run hook "configure": )

@xet7
Copy link
Member
xet7 commented Jan 15, 2018

@uusijani

Sorry, this should get it running at least on your own IP address:

mongodump --port 27019

sudo snap remove wekan

sudo snap install wekan

sudo snap set wekan root-url="http://192.168.1.10"       <== your IP address 

sudo snap set wekan port="80"

sudo systemctl restart snap.wekan.mongodb

sudo systemctl restart snap.wekan.wekan

mongorestore --drop --port 27019

I'll also continue testing this double slash fix myself.

@xet7
Copy link
Member
xet7 commented Jan 15, 2018

With Nginx and Wekan at sub-url it works for me, there is no double slash bug, with Nginx and snap settings at this page:
https://github.com/wekan/wekan/wiki/Nginx-Webserver-Config

@uusijani
Copy link
Author

@xet7 Unfortunately the install now also fails with the same configure hook issue as refresh did:

root@battra:~# snap remove wekan
wekan removed
root@battra:~# snap install wekan
error: cannot perform the following tasks:
- Run configure hook of "wekan" snap if present (run hook "configure": )

(For mongodump, I had to replace/upgrade the Xenial package with mongodb-org-tools from the main MongoDB site, because Xenial's mongodump 2.6 failed with assertion: 17369 Backing up users and roles is only supported for clusters with auth schema versions 1 or 3, found: 5. With mongodump 3.6.2 I was able to dump the db successfully.)

I came across this old Wekan snap report about the same issue. I enabled snap debugging as mentioned there, and will attach the result of grep snapd from during the installation attempt here.

Should I open a new issue about this, to keep this report on topic?

@uusijani
Copy link
Author

I noticed that the service is up locally during the (non-finishing) configuration phase, and produces journal log entries as usual, I'm attaching the relevant lines here. The gist of it appears to be an "Error: no hostname or hostnames provided in connection string" from programs/server/node_modules/fibers/future.js:280

I'm unable to reproduce this snap issue in a VM, but so far I've failed to pinpoint the curcial difference between the VM and my physical server.

I've tried purging and reinstalling snapd, disabling IPv6, turning off Apache and any other services that might be in the way, rebuilding the snap with my previous settings built in but none of it has made any difference.

@uusijani
Copy link
Author

I moved my Wekan installation to a VM until the installation issue gets resolved. In the meanwhile I can confirm that 1) the double slash issue is fixed now and 2) this edge-to-edge URL issue is still there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants
0