From 930bfadc7003a96f42eff68cd05bebf4031b8016 Mon Sep 17 00:00:00 2001 From: Antonio Goncalves Date: Mon, 6 Feb 2023 11:52:16 +0100 Subject: [PATCH 1/3] Lombok <1.18.22 is not compatible with JDK 17 --- .../openjdk17/openjdk11/lombok.windup.xml | 31 +++++++++++++++++++ .../openjdk11/tests/data/lombok/pom.xml | 17 ++++++++++ .../openjdk11/tests/lombok.windup.test.xml | 23 ++++++++++++++ 3 files changed, 71 insertions(+) create mode 100644 rules/rules-reviewed/openjdk17/openjdk11/lombok.windup.xml create mode 100644 rules/rules-reviewed/openjdk17/openjdk11/tests/data/lombok/pom.xml create mode 100644 rules/rules-reviewed/openjdk17/openjdk11/tests/lombok.windup.test.xml diff --git a/rules/rules-reviewed/openjdk17/openjdk11/lombok.windup.xml b/rules/rules-reviewed/openjdk17/openjdk11/lombok.windup.xml new file mode 100644 index 000000000..caea9cad6 --- /dev/null +++ b/rules/rules-reviewed/openjdk17/openjdk11/lombok.windup.xml @@ -0,0 +1,31 @@ + + + + + This ruleset provides analysis with respect to Lombok incompatibility between OpenJDK 11 to 17. + + + + + + + + + + + + + + + + + + Lombok supports Java 17 since version 1.18.22. The version of Lombok used in this project is too old and not compatible with Java 17. You should consider upgrading it. + + + + + + + diff --git a/rules/rules-reviewed/openjdk17/openjdk11/tests/data/lombok/pom.xml b/rules/rules-reviewed/openjdk17/openjdk11/tests/data/lombok/pom.xml new file mode 100644 index 000000000..15e0d9737 --- /dev/null +++ b/rules/rules-reviewed/openjdk17/openjdk11/tests/data/lombok/pom.xml @@ -0,0 +1,17 @@ + + 4.0.0 + org.jboss.windup.data + test + 1.0.0 + + + org.projectlombok + lombok + 1.17.0 + provided + + + Test project + \ No newline at end of file diff --git a/rules/rules-reviewed/openjdk17/openjdk11/tests/lombok.windup.test.xml b/rules/rules-reviewed/openjdk17/openjdk11/tests/lombok.windup.test.xml new file mode 100644 index 000000000..60a4454d4 --- /dev/null +++ b/rules/rules-reviewed/openjdk17/openjdk11/tests/lombok.windup.test.xml @@ -0,0 +1,23 @@ + + + data/lombok + ../lombok.windup.xml + + + + + + + + + + + + + + + + + From c2fbdec21453975c5ffd808d69f560f538d59436 Mon Sep 17 00:00:00 2001 From: Antonio Goncalves Date: Tue, 25 Apr 2023 16:18:02 +0200 Subject: [PATCH 2/3] Rule that checks Tomcat external resources for Azure migration --- .../context.xml | 22 +++++++++++ .../no-context.xml | 12 ++++++ ...o-azure-external-resources.windup.test.xml | 22 +++++++++++ ...cat-to-azure-external-resources.windup.xml | 39 +++++++++++++++++++ 4 files changed, 95 insertions(+) create mode 100644 rules/rules-reviewed/azure/tomcat/tests/data/tomcat-to-azure-external-resources/context.xml create mode 100644 rules/rules-reviewed/azure/tomcat/tests/data/tomcat-to-azure-external-resources/no-context.xml create mode 100644 rules/rules-reviewed/azure/tomcat/tests/tomcat-to-azure-external-resources.windup.test.xml create mode 100644 rules/rules-reviewed/azure/tomcat/tomcat-to-azure-external-resources.windup.xml diff --git a/rules/rules-reviewed/azure/tomcat/tests/data/tomcat-to-azure-external-resources/context.xml b/rules/rules-reviewed/azure/tomcat/tests/data/tomcat-to-azure-external-resources/context.xml new file mode 100644 index 000000000..b37a99d81 --- /dev/null +++ b/rules/rules-reviewed/azure/tomcat/tests/data/tomcat-to-azure-external-resources/context.xml @@ -0,0 +1,22 @@ + + + + WEB-INF/web.xml + WEB-INF/tomcat-web.xml + ${catalina.base}/conf/web.xml + + + + + + + diff --git a/rules/rules-reviewed/azure/tomcat/tests/data/tomcat-to-azure-external-resources/no-context.xml b/rules/rules-reviewed/azure/tomcat/tests/data/tomcat-to-azure-external-resources/no-context.xml new file mode 100644 index 000000000..af4838336 --- /dev/null +++ b/rules/rules-reviewed/azure/tomcat/tests/data/tomcat-to-azure-external-resources/no-context.xml @@ -0,0 +1,12 @@ + + + + WEB-INF/web.xml + WEB-INF/tomcat-web.xml + ${catalina.base}/conf/web.xml + + + diff --git a/rules/rules-reviewed/azure/tomcat/tests/tomcat-to-azure-external-resources.windup.test.xml b/rules/rules-reviewed/azure/tomcat/tests/tomcat-to-azure-external-resources.windup.test.xml new file mode 100644 index 000000000..c96fa9f22 --- /dev/null +++ b/rules/rules-reviewed/azure/tomcat/tests/tomcat-to-azure-external-resources.windup.test.xml @@ -0,0 +1,22 @@ + + + data/tomcat-to-azure-external-resources + ../tomcat-to-azure-external-resources.windup.xml + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/rules/rules-reviewed/azure/tomcat/tomcat-to-azure-external-resources.windup.xml b/rules/rules-reviewed/azure/tomcat/tomcat-to-azure-external-resources.windup.xml new file mode 100644 index 000000000..36f195701 --- /dev/null +++ b/rules/rules-reviewed/azure/tomcat/tomcat-to-azure-external-resources.windup.xml @@ -0,0 +1,39 @@ + + + + + Identify external resources in a Tomcat configuration file. + + + + + + + + + tomcat + + + + + + + + + + + + + tomcat + + + + + From 7cf4f3f3fbb01861b5984886ceaaabfe23c91a9c Mon Sep 17 00:00:00 2001 From: Antonio Goncalves Date: Fri, 28 Apr 2023 16:54:05 +0200 Subject: [PATCH 3/3] Update rules/rules-reviewed/azure/tomcat/tests/tomcat-to-azure-external-resources.windup.test.xml Co-authored-by: Marco Rizzi --- .../tests/tomcat-to-azure-external-resources.windup.test.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules/rules-reviewed/azure/tomcat/tests/tomcat-to-azure-external-resources.windup.test.xml b/rules/rules-reviewed/azure/tomcat/tests/tomcat-to-azure-external-resources.windup.test.xml index c96fa9f22..87d5163c8 100644 --- a/rules/rules-reviewed/azure/tomcat/tests/tomcat-to-azure-external-resources.windup.test.xml +++ b/rules/rules-reviewed/azure/tomcat/tests/tomcat-to-azure-external-resources.windup.test.xml @@ -9,7 +9,7 @@ - +