8000 add an `--interactive` option to the `Plot` command · Issue #95 · xin-huang/dadi-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add an --interactive option to the Plot command #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an iss 8000 ue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xin-huang opened this issue Jan 28, 2024 · 6 comments
Open

add an --interactive option to the Plot command #95

xin-huang opened this issue Jan 28, 2024 · 6 comments
Assignees
@xin-huang
Labels
enhancement New feature or request

Comments

@xin-huang
Copy link
Owner

I think we could add an --interactive option to the Plot command, allowing users to choose whether to display figures in the terminal. This would enhance the integration of dadi-cli with snakemake.
@xin-huang xin-huang self-assigned this Jan 28, 2024
@RyanGutenkunst RyanGutenkunst added the enhancement New feature or request label Jan 30, 2024
@RyanGutenkunst
Copy link
Collaborator

Agreed. Good idea.

@tjstruck
Copy link
Collaborator
tjstruck commented Feb 6, 2024 •
edited
Loading

I have the code for this ready, but the easiest way is for show arguments in dadi.Plotting functions to default to False instead of True. Is there any issue with changing that?

@xin-huang
Copy link
Owner Author

Thanks @tjstruck

Could you please upload your code and open a pull request? This will allow us to review the code and make any necessary additions.

@tjstruck
Copy link
Collaborator
tjstruck commented Feb 6, 2024 •
edited
Loading

@xin-huang, I've pushed a pull request for the plot-interactive-flag branch. The dadi branch that is most compatible is plot-show-option.

@tjstruck
Copy link
Collaborator
tjstruck commented Mar 5, 2024

I've pushed an update to dadi Plotting, so the master branch of dadi should now work appropriately with or without the --interactive command.

@xin-huang
Copy link
Owner Author

Thank you. I am currently focusing on my machine learning project and will look into dadi-cli once we receive the feedback from the reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xin-huang xin-huang

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RyanGutenkunst @xin-huang @tjstruck
0