8000 Switch from Schema to clojure.spec · Issue #576 · yetibot/yetibot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Switch from Schema to clojure.spec #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
devth opened this issue Jul 13, 2016 · 5 comments
Closed

Switch from Schema to clojure.spec #576

devth opened this issue Jul 13, 2016 · 5 comments
Labels
P0 Fix this ASAP refactoring

Comments

@devth
Copy link
Member
devth commented Jul 13, 2016 •
edited
Loading
  • spec the minimum attributes and their types for a user model e.g. {:id "~yetibot" :username "yetibot"}
  • use spec for config shapes
  • spec the irc object in Slack so we know what data are available
  • adapters
  • warn loudly in logs when a namespace tries to load its config but it's invalid
@devth devth mentioned this issue Jul 5, 2017
Open
@devth devth added the ready label Aug 29, 2017
@devth devth added the P0 Fix this ASAP label Nov 23, 2017
@cvic
Copy link
Member
cvic commented May 23, 2018

Does
(defn non-blank-string? [x] (and (string? x) (not (string/blank? x))))

look like a good replacement for
https://github.com/yetibot/yetibot.core/blob/master/src/yetibot/core/schema.clj#L5 ?

@devth
Copy link
Member Author

Sure. Where's that? Or is that new code you're proposing we introduce?

@cvic
Copy link
Member
cvic commented May 23, 2018

New code. I have to test it first.

@cvic
Copy link
Member
cvic commented May 30, 2018

I'll start with
https://github.com/yetibot/yetibot.core/blob/master/src/yetibot/core/util/config.clj#L56

and use this for inspiration
https://gist.github.com/ghoseb/9f81ca592a56c23a4f7564e813d23ea5#file-clj_spec_playground-clj-L75

@devth devth mentioned this issue Jan 13, 2019
Open
@devth devth added in progress and removed ready labels Jan 13, 2019
@devth
Copy link
Member Author
devth commented Sep 10, 2019

@devth devth closed this as completed Sep 10, 2019
@devth devth removed the in progress label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P0 Fix this ASAP refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devth @cvic
0