8000 Feature request: Do not update finished date on finishing rewatching entries · Issue #775 · z411/trackma · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature request: Do not update finished date on finishing rewatching entries #775

New issue

Have a question about this project? Sign up for a free GitHub account to ope 8000 n an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sudoAlphaX opened this issue May 25, 2025 · 5 comments
Open

Feature request: Do not update finished date on finishing rewatching entries #775

sudoAlphaX opened this issue May 25, 2025 · 5 comments
Labels
enhancement

Comments

@sudoAlphaX
Copy link

Avoid updating finished date on completion of rewatching episodes. It causes loss of the original finished date.
Or provide an option to not update dates on rewatching episodes, and instead just update the progress.

I will be working on a PR to implement this feature, if this idea is accepted.
@FichteFoll
Copy link
Collaborator
FichteFoll commented May 25, 2025 •
edited
Loading

Related: #385

Edit: Ah, and yes, I agree that it should not do that. Please also skip setting the started day for rewatching shows while you're at it, like is mentioned in the referenced issue.

@sudoAlphaX
Copy link
Author

Alright, ill work on it.
8000

@z411
Copy link
Owner
z411 commented May 26, 2025 •
edited
Loading

I'm not sure if we should provide the option, I don't think this is desirable at all? And if it is, not updating the dates should be the default IMO. I mostly agree with what ajariel proposed in the referenced issue:

I propose that the program only updates the date if it's not already set, otherwise never touch it.

@FichteFoll
Copy link
Collaborator

This exact proposed behavior actually has practical implications for me if it is not also limited to the rewatching state, because adding a title on anilist (the website) as "watching" also sets the start date to today despite remaining at 0 watched episodes. When I eventually watch the first episode, trackma then correctly updates the start date despite one already being there, which is exactly what I want.

@z411
Copy link
Owner
z411 commented May 26, 2025

Ah, right. Yeah, makes sense. In that case we should only touch the dates if it's the first time watching and finishing the show. The mediainfo holds a statuses_start field, and in AniList case it is ['CURRENT', 'REPEATING'] (Watching and Rewatching respectively). Therefore technically we should change the dates only if we're moving to/from [0].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@FichteFoll @z411 @sudoAlphaX
0