Issue 11439 : clicking own name in the buddy list, should open user info popup #11441
Conversation
|
Hello @zulip/server-sidebars members, this pull request was labeled with the "area: right-sidebar" label, so you may want to check it out! |
|
@showell @timabbott Ready for review |
|
@timabbott This LGTM. It's a pretty concise way of doing it using selectors and a little extra markup. The other alternative would be for the handler to check I think I like this approach. |
|
Actually, one thing--I believe these can all be squashed into a single commit. |
|
Thanks for the review. I will squash them into a single commit message. |
|
FYI here's some feedback from Rishi: https://chat.zulip.org/#narrow/stream/101-design/topic/user.20status.20design/near/694978 Tim, it's probably worth giving this a quick look, anyway, just to get a feel for it. |
da122f3 to
05236fb
Compare
Add markup to identify current user. Remove the click handler and href for the current user DOM element to avoid opening PM narrow of current user with itself. Open user info popover when curent user clicks it's name. Fixes zulip#11439.
05236fb to
57e6e7c
Compare
|
@showell Squashed the 3 commits into one. |
|
Cool; I'm going to defer looking at this until I have a 2.0 release candidate posted. |
|
@timabbott Please review when you get time. Thank you. |
|
The code is a fine implementation of the concept; I think there's some question on whether we want to make this change from a product perspective. @thedeveloperr I encourage you to move on to other issues for now, and we'll leave this open until we can make a decision. |
|
Heads up @thedeveloperr, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
4ec3636 to
88b200c
Compare
#11439
When you click on your own name in the buddy list, we should go right to the popup
Testing Plan:
Click on my your name in buddy list and user info popup should appear instead of a Private message narrow with yourself.
GIFs or Screenshots:
