8000 False-valued reductions/extracts are not rendered in CSV exports. · Issue #1180 · zooniverse/caesar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

False-valued reductions/extracts are not rendered in CSV exports. #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hughdickinson opened this issue Jul 7, 2020 · 0 comments
Open

False-valued reductions/extracts are not rendered in CSV exports. #1180

hughdickinson opened this issue Jul 7, 2020 · 0 comments

Comments

@hughdickinson
Copy link
Collaborator

The check against present on this line:

caesar/app/models/exporters/csv_exporter.rb

Line 58 in 4c0ca58

return "" unless item.present?

returns false for false valued boolean data.

This means that reducers which return boolean valued data e.g.

{"result": false}

Will produce an empty column in the resultant data export for all reductions that return false.

The expected result is that a literal false value should be output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hughdickinson
0