8000 textgrad.optimizer.optimizer_prompts.py lacks one argument for class TextualGradientDescentwithMomentum(Optimizer) · Issue #157 · zou-group/textgrad · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

textgrad.optimizer.optimizer_prompts.py lacks one argument for class TextualGradientDescentwithMomentum(Optimizer) #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Zixind opened this issue Mar 4, 2025 · 1 comment
Open

textgrad.optimizer.optimizer_prompts.py lacks one argument for class TextualGradientDescentwithMomentum(Optimizer) #157

Zixind opened this issue Mar 4, 2025 · 1 comment

Comments

@Zixind
Copy link
Zixind commented Mar 4, 2025

In class TextualGradientDescentwithMomentum(Optimizer): for def _update_prompt(self, variable: Variable, momentum_storage_idx: int):
the function does not return anything. It needs to have "return prompt" otherwise in step(self), prompt_update_parameter = self._update_prompt(parameter, momentum_storage_idx=idx), prompt_update_parameter would be null.
@vinid
Copy link
Collaborator
vinid commented Mar 4, 2025

yea we unfortunately never fixed this issue #96, would you have time to send a fix in a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vinid @Zixind
0