8000 Converting O to Zero · Issue #15 · 365Werk/identitydocuments · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Converting O to Zero #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
callingearth opened this issue Feb 13, 2021 · 2 comments · Fixed by #25
Closed

Converting O to Zero #15

callingearth opened this issue Feb 13, 2021 · 2 comments · Fixed by #25
Assignees
@HergenD
Labels
2.0.0 Scheduled for 2.0.0 release

Comments

@callingearth
Copy link

Seems like converting the letter 'O' to number zero with $document->parsed->document_number is not enough, it needs to be done as well with $document->parsed->check_document_number. I had this issue with a document_number that ended with 7910 followed by check_document_number '0' (zero) which was returned as letter 'O' from the google api.

I was able to fix that by adding the following line as line 249 in src/IdentityDocuments.php
$document->parsed->check_document_number = preg_replace($re, $subst, $document->parsed->check_document_number);

I haven't done any exhaustive testing so I don't create a pull request, but this seems to have fixed the problem for me anyway.
@HergenD
Copy link
Member
HergenD commented Mar 26, 2021

Thanks for the issue, I'll look into this

@HergenD HergenD self-assigned this Mar 26, 2021
@HergenD
Copy link
Member
HergenD commented Mar 30, 2021

As a slight update, version 2.0 is in the works which will address both this and the other open issue

@HergenD HergenD added the 2.0.0 Scheduled for 2.0.0 release label Apr 8, 2021
This was referenced Apr 27, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HergenD HergenD

Labels
2.0.0 Scheduled for 2.0.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release/2.0.0 365Werk/identitydocuments
Release/2.0.0 365Werk/identitydocuments
2 participants
@HergenD @callingearth
0