[bugfix] ts: toISOString function also return null #5827
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandfresh
approved these changes
Jan 10, 2023
|
Merged in 651dff4 |
ichernev
added a commit
that referenced
this pull request
Dec 24, 2023
[bugfix] ts: toISOString function also return null
|
Sorry, I had to revert this. TS code breaks after the change: #6194 |
mergify bot
referenced
this pull request
in SvenKirschbaum/musikbot-frontend
Dec 29, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | | | lockFileMaintenance | All locks refreshed | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/react](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react)) | devDependencies | patch | [`17.0.73` -> `17.0.74`](https://renovatebot.com/diffs/npm/@types%2freact/17.0.73/17.0.74) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [moment](https://momentjs.com) ([source](https://togithub.com/moment/moment)) | dependencies | minor | [`2.29.4` -> `2.30.1`](https://renovatebot.com/diffs/npm/moment/2.29.4/2.30.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [react-stomp-hooks](https://togithub.com/SvenKirschbaum/react-stomp-hooks) | dependencies | minor | [`2.1.0` -> `2.2.1`](https://renovatebot.com/diffs/npm/react-stomp-hooks/2.1.0/2.2.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | 🔧 This Pull Request updates lock files to use the latest dependency versions. --- ### Release Notes <details> <summary>moment/moment (moment)</summary> ### [`v2.30.1`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2301) [Compare Source](https://togithub.com/moment/moment/compare/2.30.0...2.30.1) - Release Dec 27, 2023 - Revert [https://github.com/moment/moment/pull/5827](https://togithub.com/moment/moment/pull/5827), because it's breaking a lot of TS code. ### [`v2.30.0`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2300-Full-changelog) [Compare Source](https://togithub.com/moment/moment/compare/2.29.4...2.30.0) - Release Dec 26, 2023 </details> <details> <summary>SvenKirschbaum/react-stomp-hooks (react-stomp-hooks)</summary> ### [`v2.2.1`](https://togithub.com/SvenKirschbaum/react-stomp-hooks/compare/v2.2.0...v2.2.1) [Compare Source](https://togithub.com/SvenKirschbaum/react-stomp-hooks/compare/v2.2.0...v2.2.1) ### [`v2.2.0`](https://togithub.com/SvenKirschbaum/react-stomp-hooks/compare/v2.1.0...v2.2.0) [Compare Source](https://togithub.com/SvenKirschbaum/react-stomp-hooks/compare/v2.1.0...v2.2.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/musikbot-frontend).
mergify bot
referenced
this pull request
in SvenKirschbaum/md-frontend
Dec 31, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | | | lockFileMaintenance | All locks refreshed | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@testing-library/jest-dom](https://togithub.com/testing-library/jest-dom) | devDependencies | patch | [`6.1.5` -> `6.1.6`](https://renovatebot.com/diffs/npm/@testing-library%2fjest-dom/6.1.5/6.1.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@testing-library/user-event](https://togithub.com/testing-library/user-event) | devDependencies | patch | [`14.5.1` -> `14.5.2`](https://renovatebot.com/diffs/npm/@testing-library%2fuser-event/14.5.1/14.5.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [moment](https://momentjs.com) ([source](https://togithub.com/moment/moment)) | dependencies | minor | [`2.29.4` -> `2.30.1`](https://renovatebot.com/diffs/npm/moment/2.29.4/2.30.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | 🔧 This Pull Request updates lock files to use the latest dependency versions. --- ### Release Notes <details> <summary>testing-library/jest-dom (@​testing-library/jest-dom)</summary> ### [`v6.1.6`](https://togithub.com/testing-library/jest-dom/releases/tag/v6.1.6) [Compare Source](https://togithub.com/testing-library/jest-dom/compare/v6.1.5...v6.1.6) ##### Bug Fixes - Upgrade [@​adobe/css-tools](https://togithub.com/adobe/css-tools) to v4.3.2 ([#​553](https://togithub.com/testing-library/jest-dom/issues/553)) ([b64b953](https://togithub.com/testing-library/jest-dom/commit/b64b953f76170f282c73329ee3479ede13610713)) </details> <details> <summary>testing-library/user-event (@​testing-library/user-event)</summary> ### [`v14.5.2`](https://togithub.com/testing-library/user-event/releases/tag/v14.5.2) [Compare Source](https://togithub.com/testing-library/user-event/compare/v14.5.1...v14.5.2) ##### Bug Fixes - remove interop and deep DTL imports ([6a3c896](https://togithub.com/testing-library/user-event/commit/6a3c896bd2d77d284c6deab4f4f02c0fb366824b)) </details> <details> <summary>moment/moment (moment)</summary> ### [`v2.30.1`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2301) [Compare Source](https://togithub.com/moment/moment/compare/2.30.0...2.30.1) - Release Dec 27, 2023 - Revert [https://github.com/moment/moment/pull/5827](https://togithub.com/moment/moment/pull/5827), because it's breaking a lot of TS code. ### [`v2.30.0`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2300-Full-changelog) [Compare Source](https://togithub.com/moment/moment/compare/2.29.4...2.30.0) - Release Dec 26, 2023 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/md-frontend).
renovate bot
referenced
this pull request
in valora-inc/wallet
Jan 6, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [moment](https://momentjs.com) ([source](https://togithub.com/moment/moment)) | [`^2.29.4` -> `^2.30.1`](https://renovatebot.com/diffs/npm/moment/2.29.4/2.30.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confiden 8000 ce/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>moment/moment (moment)</summary> ### [`v2.30.1`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2301) [Compare Source](https://togithub.com/moment/moment/compare/2.30.0...2.30.1) - Release Dec 27, 2023 - Revert [https://github.com/moment/moment/pull/5827](https://togithub.com/moment/moment/pull/5827), because it's breaking a lot of TS code. ### [`v2.30.0`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2300-Full-changelog) [Compare Source](https://togithub.com/moment/moment/compare/2.29.4...2.30.0) - Release Dec 26, 2023 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
But this would be correct, right? The Date.toISOString() spec says it either returns a Should Moment.js do the same? |
renovate bot
referenced
this pull request
in openedx/edx-ui-toolkit
Apr 8, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [moment](https://momentjs.com) ([source](https://togithub.com/moment/moment)) | [`2.29.4` -> `2.30.1`](https://renovatebot.com/diffs/npm/moment/2.29.4/2.30.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>moment/moment (moment)</summary> ### [`v2.30.1`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2301) [Compare Source](https://togithub.com/moment/moment/compare/2.30.0...2.30.1) - Release Dec 27, 2023 - Revert [https://github.com/moment/moment/pull/5827](https://togithub.com/moment/moment/pull/5827), because it's breaking a lot of TS code. ### [`v2.30.0`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#2300-Full-changelog) [Compare Source](https://togithub.com/moment/moment/compare/2.29.4...2.30.0) - Release Dec 26, 2023 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/openedx/edx-ui-toolkit). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Jan 16, 2025
<
6759
/option>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toISOString(keep Offset?: boolean) function return string or null.
So, please rewrite moment.d.ts .