8000 Update workflows to use reusable-workflows by jongwooo · Pull Request #1066 · actions/cache · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update workflows to use reusable-workflows #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 17, 2023
Merged

Update workflows to use reusable-workflows #1066

merged 3 commits into from
Jan 17, 2023

Conversation

jongwooo
Copy link
Contributor

Signed-off-by: jongwooo jongwooo.han@gmail.com

Description

In the scope of this PR we update workflows in the repo to use reusable-workflows from the repo.

Related Issues / PRs

actions/setup-node#647

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jongwooo jongwooo requested a review from a team as a code owner January 10, 2023 15:26
@github-actions github-actions bot requested a review from vsvipul January 10, 2023 15:26
@jongwooo jongwooo marked this pull request as draft January 10, 2023 15:28
@jongwooo jongwooo marked this pull request as ready for review January 10, 2023 15:38
@vsvipul vsvipul assigned tiwarishub and unassigned vsvipul Jan 13, 2023
@vsvipul vsvipul requested review from tiwarishub and removed request for vsvipul January 13, 2023 10:48
@vsvipul
Copy link
Contributor
vsvipul commented Jan 13, 2023

@jongwooo Thank you for opening this. Please fixed the licensed check as well by running licensed cache on your local setup.

@jongwooo
Update workflows to use reusable-workflows
a464b1e 
Signed-off-by: jongwooo <jongwooo.han@gmail.com>
@jongwooo
fix: Update the out-of-date metadata files
07545b1 
Signed-off-by: jongwooo <jongwooo.han@gmail.com>
@jongwooo
Copy link
Contributor Author

@vsvipul Thank you for your review! I pushed a commit.

bishal-pdMSFT
bishal-pdMSFT reviewed Jan 13, 2023
View reviewed changes
tiwarishub
tiwarishub reviewed Jan 17, 2023
View reviewed changes
tiwarishub
tiwarishub approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor
@tiwarishub tiwarishub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Left one minor comment

@tiwarishub tiwarishub merged commit 4791017 into actions:main Jan 17, 2023
@jongwooo jongwooo deleted the chore/apply-reusable-workflows branch January 17, 2023 11:58
@Teddy-van-Jerry Teddy-van-Jerry mentioned this pull request Jan 31, 2023
Merged
@renovate renovate bot mentioned this pull request Nov 9, 2023
Open
1 task
Dakshjain1 pushed a commit to SvavaCapital/cache that referenced this pull request Apr 19, 2024
@jongwooo @tiwarishub @Dakshjain1
Update workflows to use reusable-workflows (actions#1066)
8d71492 
* Update workflows to use reusable-workflows

Signed-off-by: jongwooo <jongwooo.han@gmail.com>

* fix: Update the out-of-date metadata files

Signed-off-by: jongwooo <jongwooo.han@gmail.com>

Signed-off-by: jongwooo <jongwooo.han@gmail.com>
Co-authored-by: Shubham Tiwari <64764738+tiwarishub@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishal-pdMSFT bishal-pdMSFT bishal-pdMSFT left review comments

@tiwarishub tiwarishub 5606 tiwarishub approved these changes

Assignees

@tiwarishub tiwarishub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jongwooo @vsvipul @bishal-pdMSFT @tiwarishub
0