Bazel example (Take #2️⃣) #1132

vorburger · 2023-03-11T18:45:02Z

examples.md

vorburger · 2023-03-13T13:28:19Z

PiotrSikora · 2023-03-13T16:41:08Z

examples.md

+    restore-keys: |
+      ${{ runner.os }}-bazel-


I'd argue that we shouldn't do partial restore with Bazel (at least not that wide), since most of the restored files won't be used anyway, and they are going to be saved in the new cache, wasting cache space and increasing restore times.

@vsvipul I'm reluctant to make changes to a PR after a LGTM.. before I do, could you comment if you want this to be removed or not? Personally I'm not sure I see the harm in this being there, and in my project it does seem to help quite a bit to speed up things on small dependency changes. It also does not seem consistent, to me, for Bazel to be the only example where there is not restore-keys? Isn't what @PiotrSikora alludes to something that could be said for all examples and that is not specific to Bazel per se?

Skimming through examples, deno doesn't have restore-keys either.

But if you want to retain it here, I'd probably add more layers of restore-keys, e.g.:

restore-keys: | ${{ runner.os }}-bazel-${{ hashFiles('.bazelversion', '.bazelrc', 'WORKSPACE', 'WORKSPACE.bazel') }} ${{ runner.os }}-bazel-${{ hashFiles('.bazelversion', '.bazelrc') }} ${{ runner.os }}-bazel-${{ hashFiles('.bazelversion') }} ${{ runner.os }}-bazel-

Its upto you @vorburger . But in most cases we don't include the hashFiles in restore-keys the key with the hashFiles is already accounted for in an exact match. Also, in some cases we don't keep restore-keys where the restored cache might not be very useful. I don't have much clue about bazel so can't comment on that. would leave the decision to you.

Sorry, the restore-keys above is wrong, since those hashFiles would all evaluate to different hashes, even if the other files didin't change, and there would be no partial match. It should be this instead:

key: ${{ runner.os }}-bazel-${{ hashFiles('.bazelversion') }}-${{ hashFiles('.bazelrc') }}-${{ hashFiles('WORKSPACE', 'WORKSPACE.bazel') }}-${{ hashFiles('MODULE.bazel') }} restore-keys: | ${{ runner.os }}-bazel-${{ hashFiles('.bazelversion') }}-${{ hashFiles('.bazelrc') }}-${{ hashFiles('WORKSPACE', 'WORKSPACE.bazel') }} ${{ runner.os }}-bazel-${{ hashFiles('.bazelversion') }}-${{ hashFiles('.bazelrc') }} ${{ runner.os }}-bazel-${{ hashFiles('.bazelversion') }} ${{ runner.os }}-bazel-

Piotr, I believe I now finally better understand what you are after. You mean that there is a sort of "hierarchy" involved here, yes? Like this, a .bazelversion change causes the entire cache to be thrown away (which would make sense to me as well, yes), but a .bazrlrc version causes some cache reuse, etc.? That's a nice idea - but I'm personally not familiar enough with the cache action to be sure that this will really work like this. Vipul, thoughts?

The thing is that i need to know when each of these files change '.bazelversion', '.bazelrc', 'WORKSPACE', 'WORKSPACE.bazel', 'MODULE.bazel' to allow some kind of reuse for cache and I have never used bazel myself so i'm hesitant to merge something which I'm not sure about. I feel the current state of the PR is good enough for normal users.

SGTM, I don't mind if this gets merged as-is. Thanks!

@vsvipul can I do anything else to now see this get merged as-is?

no. this lgtm.

PiotrSikora · 2023-03-13T16:41:15Z

examples.md

+    restore-keys: |
+      ${{ runner.os }}-bazel-


vsvipul · 2023-03-21T06:45:56Z

Add example for Bazel

4b381be

vorburger requested a review from a team as a code owner March 11, 2023 18:45

github-actions bot requested a review from vsvipul March 11, 2023 18:45

github-actions bot assigned vsvipul Mar 11, 2023

vorburger added a commit to enola-dev/enola that referenced this pull request Mar 11, 2023

build: Improve Bazel Cache Key

1becc56

Based on actions/cache#1132. Also renames WORKSPACE to WORKSPACE.bazel.

vorburger mentioned this pull request Mar 11, 2023

build: Improve Bazel Cache Key enola-dev/enola#27

Merged

vorburger force-pushed the bazel-example branch 2 times, most recently from 59a2e9c to 354fa1b Compare March 11, 2023 18:50

vorburger added a commit to enola-dev/enola that referenced this pull request Mar 11, 2023

build: Improve Bazel Cache Key

a4ff664

Based on actions/cache#1132. Also renames WORKSPACE to WORKSPACE.bazel.

Fix example for Bazel

ef11f54

vorburger force-pushed the bazel-example branch from 354fa1b to ef11f54 Compare March 11, 2023 18:54

vsvipul reviewed Mar 13, 2023

View reviewed changes

examples.md Outdated Show resolved Hide resolved

Create separate Linux/macOS examples for Bazel

4b8460c

vsvipul reviewed Mar 13, 2023

View reviewed changes

examples.md Outdated Show resolved Hide resolved

examples.md Show resolved Hide resolved

vorburger and others added 2 commits March 13, 2023 14:26

Clarify that macos-latest image has bazelisk

6f1f1e1

Merge branch 'main' into bazel-example

8f2671f

vsvipul approved these changes Mar 13, 2023

View reviewed changes

PiotrSikora reviewed Mar 13, 2023

View reviewed changes

vorburger added a commit to enola-dev/enola that referenced this pull request Mar 16, 2023

build: Improve Bazel Cache Key

29e1cbf

Based on actions/cache#1132. Also renames WORKSPACE to WORKSPACE.bazel.

Merge branch 'main' into bazel-example

8000

bd9b49b

vsvipul merged commit 04f198b into actions:main Mar 21, 2023

Teddy-van-Jerry mentioned this pull request Sep 11, 2023

Bump actions/cache from 3.3.1 to 3.3.2 mmcesim/mmcesim#80

Merged

renovate bot mentioned this pull request Sep 15, 2023

chore(deps): update all non-major dependencies (2.x) nuxt/nuxt#22820

Merged

1 task

renovate bot mentioned this pull request Oct 7, 2023

chore(deps): update all non-major dependencies druxt/demo.druxtjs.org#30

Open

1 task

vrslev mentioned this pull request Jan 22, 2024

Bump actions/cache from 3 to 4 vrslev/jack_server#110

Merged

vrslev mentioned this pull request Jan 22, 2024

chore(deps): bump actions/cache from 3 to 4 vrslev/ikea-api-client#216

Merged

gucio321 mentioned this pull request Jan 22, 2024

build(deps): bump actions/cache from 3 to 4 gucio321/tic-tac-go#225

Merged

jamesmstone mentioned this pull request Jan 23, 2024

Bump actions/cache from 3 to 4 jamesmstone/parkrun#4

Merged

knuthartmark pushed a commit to knuthartmark/cache that referenced this pull request May 16, 2024

Merge pull request actions#1132 from vorburger/bazel-example

a1cade1

Bazel example (Take #2️⃣)

knuthartmark pushed a commit to knuthartmark/cache that referenced this pull request May 18, 2024

Merge pull request actions#1132 from vorburger/bazel-example

a34f71d

Bazel example (Take #2️⃣)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bazel example (Take #2️⃣) #1132

Bazel example (Take #2️⃣) #1132

Bazel example (Take #2️⃣) #1132

Bazel example (Take #2️⃣) #1132

Conversation

How Has This Been Tested?

Types of changes

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment