-
Notifications
You must be signed in to change notification settings - Fork 1.6k
NPM Audit Fixes #2043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPM Audit Fixes #2043
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates dependency versions in packages/artifact/package.json
to resolve audit vulnerabilities.
- Bumped
@actions/github
from^5.1.1
to^6.0.0
- Bumped
@octokit/core
from^3.5.1
to^5.2.1
and added@octokit/plugin-paginate-rest
- Bumped
@octokit/request-error
from^5.0.0
to^5.1.1
Files not reviewed (1)
- packages/artifact/package-lock.json: Language not supported
Comments suppressed due to low confidence (4)
packages/artifact/package.json:44
- Since this is a major version bump with potential breaking changes, add or update tests for workflows using @actions/github to ensure compatibility.
"@actions/github": "^6.0.0"
packages/artifact/package.json:47
- This major version bump may include breaking changes; verify and add tests for Octokit API calls accordingly.
"@octokit/core": "^5.2.1"
packages/artifact/package.json:48
- New pagination plugin added—ensure you include tests for paginated API endpoints to validate correct behavior.
"@octokit/plugin-paginate-rest": "^9.2.2"
packages/artifact/package.json:51
- Update tests around error handling to cover any changes introduced in @octokit/request-error v5.1.1.
"@octokit/request-error": "^5.1.1"
6acd85a
to
2b47632
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Toolkit audit is failing due to some vulnerabilities in dependencies. This PR updates the dependencies to fix the vulnerabilities, starting with
github
, which we'll need to release to address the vulnerabilities in the other packages that depend on it.