8000 Pin aquasecuriy/setup-trivy to hash instead of tag by lhotari · Pull Request #456 · aquasecurity/trivy-action · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Pin aquasecuriy/setup-trivy to hash instead of tag #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025

Conversation

lhotari
Copy link
Contributor
@lhotari lhotari commented Apr 2, 2025

Fixes #423

Pin aquasecurity/setup-trivy to hash instead of a tag so that GitHub Actions
"allowing select actions" feature can be used to whitelist the dependent action by a hash.
This is needed since some organizations have a policy to only allow pinned 3rd party actions to
be used. "Pin actions to a full length commit SHA" is recommended by GitHub and many organizations follow this best practice.

It's not currently possible to use trivy-action since the dependent action isn't pinned. This PR fixes that. More details in #423.

@CLAassistant
Copy link
CLAassistant commented Apr 2, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member
@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, what do you think @DmitriyLewen?

Copy link
Contributor
@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and logical for me.

Left small comment

@lhotari lhotari requested a review from DmitriyLewen April 7, 2025 06:46
Copy link
Contributor
@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lhotari Thanks for your work!

LGTM

cc. @simar7

@simar7 simar7 merged commit 99baf0d into aquasecurity:master Apr 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow pinning setup-trivy by hash
4 participants
0