8000 Map SmartThings auto mode correctly by joostlek · Pull Request #145061 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Map SmartThings auto mode correctly #145061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

Map SmartThings auto mode correctly #145061

merged 1 commit into from
May 16, 2025

Conversation

joostlek
Copy link
Member

Breaking change

I am not sure if this qualifies as a breaking change

Proposed change

Map SmartThings auto mode correctly, as the auto mode should map to auto

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek joostlek added this to the 2025.5.2 milestone May 16, 2025
@frenck frenck merged commit 87b6096 into home-assistant:dev May 16, 2025
34 checks passed
@joostlek joostlek deleted the st-auto branch May 16, 2025 18:17
frenck pushed a commit that referenced this pull request May 16, 2025
@joostlek @frenck
Map SmartThings auto mode correctly (#145061)
e2ede3e
@frenck frenck mentioned this pull request May 16, 2025
Merged
@RichardD012
Copy link

This is definitely a breaking change. I can no longer control the HEAT/COOL mode of my thermostat. Auto mode in smart things is heat/cool.

@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chemelli74 chemelli74 chemelli74 approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: smartthings Quality Scale: bronze small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.5.2
Development

Successfully merging this pull request may close these issues.

"auto" mode shows Heat/Cool in UI because of incorrect mapping in climate smartthings
4 participants
@joostlek @RichardD012 @chemelli74 @frenck
0