Include installed Test Frameworks in TestFrameworkTypes - Fixes 1863 #1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thompsnm
commented
Jun 23, 2023
| ): array { | ||
| $types = self::$defaultTypes; | ||
|
|
||
| if (count($installedExtensions) > 0) { |
There was a problem hiding this comment.
I see there's a warning from "GitHub Actions / Mutation Testing Code Review Annotations 8.1" on this line that changing > to >= is an escaped Mutant. I just confirmed that this case would be caught by phpstan analyse:
------ ---------------------------------------------------------------------
Line TestFramework/TestFrameworkTypes.php
------ ---------------------------------------------------------------------
74 Comparison operation ">=" between int<0, max> and 0 is always true.
------ ---------------------------------------------------------------------
sanmai
reviewed
Jun 25, 2023
| Assert::classExists($factory); | ||
|
|
||
| if (!is_a($factory, TestFrameworkAdapterFactory::class, true)) { | ||
| continue; |
There was a problem hiding this comment.
Should we throw here instead, telling user they made a mistake?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Fixes #1863
Per the issue description:
My team has implemented a binary that wraps around PHPUnit and configures / executes tests for us when we simply point it at a particular directory. I want to implement an Infection Test Framework extension that we would only use internally that executes tests via our binary. Unfortunately, that's not possible because specifying a Test Framework whose type is not hardcoded in TestFrameworkTypes causes Infection to throw an error.
Changes mage:
I replaced all references to the constant array
TestFrameworkTypes::TYPESwith a static functionTestFrameworkTypes::getTypes()that parsesGeneratedExtensionsConfig::EXTENSIONSto include the names of all installed Adapters.