8000 Remove symfony/console < 4.4 hack as minimum supported version is 5.4 by sidz · Pull Request #1888 · infection/infection · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove symfony/console < 4.4 hack as minimum supported version is 5.4 #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sidz
Copy link
Member
@sidz sidz commented Oct 19, 2023

This PR removes some hack which was applied when Infection supported symfony/console < 4.4

Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

Copy link
Member
@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @sidz

@maks-rafalko maks-rafalko merged commit 77148ed into master Oct 19, 2023
@maks-rafalko maks-rafalko deleted the remove-no-longer-supported-symfony-console-hack branch October 19, 2023 22:05
github-merge-queue bot referenced this pull request in Lendable/clock Nov 2, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [infection/infection](https://togithub.com/infection/infection) |
`^0.27.6` -> `^0.27.7` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/infection%2finfection/0.27.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/infection%2finfection/0.27.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/infection%2finfection/0.27.6/0.27.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/infection%2finfection/0.27.6/0.27.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>infection/infection (infection/infection)</summary>

###
[`v0.27.7`](https://togithub.com/infection/infection/releases/tag/0.27.7):
PHP 8.3, Symfony 7 support

[Compare
Source](https://togithub.com/infection/infection/compare/0.27.6...0.27.7)

**Changed:**

- Add Symfony 7 support by [@&#8203;sidz](https://togithub.com/sidz) in
[https://github.com/infection/infection/pull/1892](https://togithub.com/infection/infection/pull/1892)
- Allow `fidry/cpu-core-counter` v1 by
[@&#8203;Slamdunk](https://togithub.com/Slamdunk) in
[https://github.com/infection/infection/pull/1893](https://togithub.com/infection/infection/pull/1893)
- Micro optimization to reduce array_merge calls by
[@&#8203;sidz](https://togithub.com/sidz) in
[https://github.com/infection/infection/pull/1883](https://togithub.com/infection/infection/pull/1883)
- Remove `symfony/console` < 4.4 hack as minimum supported version is
5.4 by [@&#8203;sidz](https://togithub.com/sidz) in
[https://github.com/infection/infection/pull/1888](https://togithub.com/infection/infection/pull/1888)
- Remove all deprecated Safe function usages by
[@&#8203;sidz](https://togithub.com/sidz) in
[https://github.com/infection/infection/pull/1889](https://togithub.com/infection/infection/pull/1889)
- Update sanmai/pipeline to the latest version by
[@&#8203;sanmai](https://togithub.com/sanmai) in
[https://github.com/infection/infection/pull/1890](https://togithub.com/infection/infection/pull/1890)

**Full Changelog**:
infection/infection@0.27.6...0.27.7

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Lendable/clock).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0