8000 Add support for `colinodell/json5` v3 by Slamdunk · Pull Request #1976 · infection/infection · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for colinodell/json5 v3 #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

Slamdunk
Copy link
Contributor
@Slamdunk Slamdunk commented Jun 5, 2024

The composer.lock has been updated with the following command:

$ docker compose run php81 composer update

@maks-rafalko
Copy link
Member

docker compose run php81 composer update

shouldn't it be just docker compose run php81 composer update colinodell/json5?

I mean, this updated all the deps, besides colinodell/json5, which broke the build.

@Slamdunk
Copy link
Contributor Author
Slamdunk commented Jun 5, 2024

Indeed 🙈

@maks-rafalko maks-rafalko enabled auto-merge (squash) June 5, 2024 06:51
@maks-rafalko maks-rafalko changed the base branch from 0.29 to master June 5, 2024 07:23
@maks-rafalko maks-rafalko disabled auto-merge June 5, 2024 07:24
@maks-rafalko maks-rafalko merged commit 105e929 into infection:master Jun 5, 2024
55 checks passed
@maks-rafalko
Copy link
Member

Thank you @Slamdunk

@maks-rafalko
Copy link
Member

@maks-rafalko
Copy link
Member

By the way, added info about target default branch, 99e03a7

this is why GH actions didn't work properly, not finishing with status reports.

@Slamdunk Slamdunk deleted the json5_v3 branch June 5, 2024 07:29
@Slamdunk
Copy link
Contributor Author
Slamdunk commented Jun 5, 2024

That's weird to me: I expected master to hold the upcoming MAJOR release with BC-Breaking changes, and 0.29 the upcoming MINOR rel 8000 ease.

If that's not the case, which is the branch I'll have to push my PR against, when proposing BC-Breaking changes?

@maks-rafalko
Copy link
Member

In general, you are right and I'm sure after 1.0 release we will revise the current branching model and it will be something like you expect.

However right now we are still on 0.x and historically we use "master-based development", we just merge everything in master and it becomes the next release. We are trying to not break BC, but that's kind of ok on 0.x (even composer treats 0.3.0 -> 0.4.0 as a "major" release with potential BC breaks.

If that's not the case, which is the branch I'll have to push my PR against, when proposing BC-Breaking changes?

so, answering to your question, now it will be just master

github-merge-queue bot referenced this pull request in Lendable/json-serializer Jun 6, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [infection/infection](https://togithub.com/infection/infection) |
`^0.29.2` -> `^0.29.3` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/infection%2finfection/0.29.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/infection%2finfection/0.29.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/infection%2finfection/0.29.2/0.29.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/infection%2finfection/0.29.2/0.29.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>infection/infection (infection/infection)</summary>

###
[`v0.29.3`](https://togithub.com/infection/infection/releases/tag/0.29.3):
Add support for &#x60;colinodell/json5&#x60; v3

[Compare
Source](https://togithub.com/infection/infection/compare/0.29.2...0.29.3)

**Changed:**

- Add support for `colinodell/json5` v3 by
[@&#8203;Slamdunk](https://togithub.com/Slamdunk) in
[https://github.com/infection/infection/pull/1976](https://togithub.com/infection/infection/pull/1976)

**Full Changelog**:
infection/infection@0.29.2...0.29.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Lendable/json-serializer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODguMSIsInVwZGF0ZWRJblZlciI6IjM3LjM4OC4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0