Ignore switch(bool) statements in TrueValue and FalseValue mutators. #1986
Conversation
|
NOTE: The test cases could probably use particular attention. My test cases are asserting that switch statements are NOT mutated. I am not familiar with the Infection codebase, and could not find equivalent test cases or assertions to base mine upon, so it may or may not need massaging. All test cases behave as I would expect, otherwise. Here, specifically, is how I have accomplished this assertion: infection/src/Testing/BaseMutatorTestCase.php Lines 116 to 123 in e7aa2fd |
| PHP; | ||
|
|
||
| $this->assertInputNotMutated($inputCode); | ||
| } |
There was a problem hiding this comment.
actually, you don't need to create separate method to test the case when no mutation is happening.
Please, look here to get an example:
infection/tests/phpunit/Mutator/Boolean/FalseValueTest.php
Lines 74 to 81 in a663d6c
so you basically need to create the same yield with switch (false). Thus, new created method assertInputNotMutated can also be removed
Head branch was pushed to by a user without write access
|
Thanks for the feedback @maks-rafalko. I had a feeling there was a better way... |
This PR:
Fixes #819
This will stop false positives related to boolean values in switch conditions, where no code coverage has been detected.