8000 Get rid of Symfony 5.4 support as it's EOLed and on security fixes only by maks-rafalko · Pull Request #2029 · infection/infection · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Get rid of Symfony 5.4 support as it's EOLed and on security fixes only #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 13, 2025
Merged

Get rid of Symfony 5.4 support as it's EOLed and on security fixes only #2029

merged 5 commits into from
Feb 13, 2025

Conversation

maks-rafalko
Copy link
Member

https://symfony.com/releases

2 reasons for this:

  • Symfony 5.4 is dead, security fixes only
  • We don't have quotes for so many GH Actions, so removing Symfony 5.4 from the matrix will greatly speed up our builds. Currently, when quotes for 1 PR are used, we have to wait a coupls of minutes for the next GH Actions to be started, they are hanging in a pending state
image

@private-packagist Private Packagist
Copy link
Contributor
private-packagist bot commented Feb 13, 2025 •
edited
Loading

composer.lock

Package changes

Package Operation From To About
symfony/console upgrade v6.4.4 v7.2.1 diff
symfony/deprecation-contracts upgrade v3.4.0 v3.5.1 diff
symfony/filesystem upgrade v6.4.13 v7.2.0 diff
symfony/finder upgrade v5.4.27 v7.2.2 diff
symfony/polyfill-ctype upgrade v1.29.0 v1.31.0 diff
symfony/polyfill-intl-grapheme upgrade v1.29.0 v1.31.0 diff
symfony/polyfill-intl-normalizer upgrade v1.29.0 v1.31.0 diff
symfony/polyfill-mbstring upgrade v1.29.0 v1.31.0 diff
symfony/process upgrade v6.4.14 v7.2.0 diff
symfony/service-contracts upgrade v3.4.1 v3.5.1 diff
symfony/string upgrade v6.4.4 v6.4.15 diff
symfony/polyfill-php80 remove v1.29.0 - -

Dev Package changes

Package Operation From To About
symfony/yaml upgrade v5.4.30 v7.2.3 diff

Settings · Docs · Powered by Private Packagist

@private-packagist Private Packagist
Copy link
Contributor

The composer.lock diff comment has been updated to reflect new changes in this PR.

@sidz
Copy link
Member
sidz commented Feb 13, 2025

Just a thought:
what about drop support for Symfony < 6.4 too @maks-rafalko ?

@maks-rafalko
Copy link
Member Author

what about drop support for Symfony < 6.4 too @maks-rafalko ?

like it ;) I will do later in this PR, thanks

sanmai
sanmai approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member
@sanmai sanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Say no more

@sidz
Copy link
Member
sidz commented Feb 13, 2025 •
edited
Loading

we could get rid of this kind of hack https://github.com/infection/infection/blob/master/src/FileSystem/DummyFileSystem.php#L42 too

@maks-rafalko maks-rafalko marked this pull request as ready for review February 13, 2025 15:37
@maks-rafalko
Copy link
Member Author
maks-rafalko commented Feb 13, 2025 •
edited
Loading

@sidz @sanmai please review again, addressed comments

@maks-rafalko maks-rafalko merged commit 71a7798 into master Feb 13, 2025
49 checks passed
@maks-rafalko maks-rafalko deleted the feature/remove-symfony-54 branch February 13, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanmai sanmai sanmai approved these changes

@sidz sidz sidz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maks-rafalko @sidz @sanmai
0