8000 Remove deprecated Rector's rule as it generates warnings by maks-rafalko · Pull Request #2051 · infection/infection · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove deprecated Rector's rule as it generates warnings #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

Remove deprecated Rector's rule as it generates warnings #2051

merged 1 commit into from
Feb 27, 2025

Conversation

maks-rafalko
Copy link
Member
@maks-rafalko maks-rafalko commented Feb 26, 2025 •
edited
Loading

make rector now generates warnings because of deprecated non-registered rule:

 [WARNING] Skipped rule "Rector\Php80\Rector\FunctionLike\MixedTypeRector" is deprecated

 [WARNING] Skipped rule "Rector\Php80\Rector\FunctionLike\MixedTypeRector" is never registered. You can remove it from
           "->withSkip()"

@maks-rafalko
Remode deprecated Rector's rule ast it generates warnings
2c6cc31 
`make rector` now generates warnings because of deprecated non-registered rule:

```

 [WARNING] Skipped rule "Rector\Php80\Rector\FunctionLike\MixedTypeRector" is deprecated

 [WARNING] Skipped rule "Rector\Php80\Rector\FunctionLike\MixedTypeRector" is never registered. You can remove it from
           "->withSkip()"
```
github-actions[bot]
github-actions bot previously requested changes Feb 26, 2025
View reviewed changes
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@maks-rafalko maks-rafalko changed the title Remode deprecated Rector's rule ast it generates warnings Remove deprecated Rector's rule ast it generates warnings Feb 26, 2025
@maks-rafalko maks-rafalko changed the title Remove deprecated Rector's rule ast it generates warnings Remove deprecated Rector's rule as it generates warnings Feb 26, 2025
@maks-rafalko maks-rafalko merged commit 9fa3099 into master Feb 27, 2025
50 checks passed
@maks-rafalko maks-rafalko deleted the feature/rector-deprecations branch February 27, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanmai sanmai sanmai approved these changes

@sidz sidz sidz approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maks-rafalko @sanmai @sidz
0